Re: [PATCH 01/64] driver core: set default SYSFS_DEPRECATED=n

[Pavel Machek <pavel@ucw.cz>]

Hi!

> All recent distros depend on the non-deprecated sysfs layout, so
> change the default value of the option to reflect that.
> 
> Signed-off-by: Kay Sievers <kay.sievers@vrfy.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> ---
>  init/Kconfig |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/init/Kconfig b/init/Kconfig
> index fed6dc3..c4b3c6d 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -616,13 +616,13 @@ config SYSFS_DEPRECATED
>  	bool
>  
>  config SYSFS_DEPRECATED_V2
> -	bool "Create deprecated sysfs layout for older userspace tools"
> +	bool "remove sysfs features which may confuse old userspace tools"

Should begin with capital letter. What is worse, this inverts sense of
description text, but you did not change semantics of the option.

>  	depends on SYSFS
> -	default y
> +	default n
>  	select SYSFS_DEPRECATED
>  	help
>  	  This option switches the layout of sysfs to the deprecated
> -	  version.
> +	  version. Do not use it on recent distributions.

Recent is relative. 'On distros from 2008 and onwards'?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html