Re: [PATCH 1/2] UIO: add device clock support

[Greg KH <gregkh@suse.de>]

On Wed, Jun 24, 2009 at 08:29:36PM +0200, Daniel Mack wrote:
> On Wed, Jun 24, 2009 at 09:34:14AM -0700, Greg KH wrote:
> > On Wed, Jun 24, 2009 at 05:30:24PM +0200, Daniel Mack wrote:
> > > Add a pointer to a 'struct clk' to uio_info. Drivers can set
> > > this pointer if a clock is needed, and the UIO core will care
> > > to enable and disable it upon device open and release.
> > 
> > Do you have a UIO driver that needs this?
> 
> No.
> 
> > If so, please submit it at the same time, otherwise adding
> > infrastructure for no driver that needs it, is pretty pointless.
> 
> As I wrote in my introduction email, I wanted to use this framework but
> eventually I didn't. But then I had these patches flying around and I
> thought sharing them is better than throwing them away. They work well,
> it's just that this particular feature has no uses at the moment.

Thanks for the change, it looks nice, but until we have a driver that
needs it, I say we hold off on this patch.

thanks,

greg k-h