Re: [PATCH 3/3] [ARM] msm: add minimal board file for HTC Dream device

[Pavel Machek <pavel@ucw.cz>]

On Mon 2009-06-15 11:51:57, Brian Swetland wrote:
> On Mon, Jun 15, 2009 at 11:28 AM, Pavel Machek<pavel@ucw.cz> wrote:
> > (Now... I'm trying to figure out how leds are set up. It seems that
> > there are two classes -- leds-gpio, which is backlights, and 4colored
> > led. I'd like to use 4colored led for debugging... Unfortunately
> > drivers/leds/leds-cpld.c is quite "interesting" (and really abuses
> > interface at least with "blink" file). Is there easy way to turn some
> > light manually, best something that works early and can be used for
> > debugging?)
> 
> The 4color LED is controlled by an I2C led controller, so it's a bit
> of a pain to interact with very early on.
> 
> There are LED backlights behind the keyboard and the buttons on the
> "chin" of the device, controlled by the CPLD (see
> TROUT_GPIO_QTKEY_LED_EN and TROUT_GPIO_UI_LED_EN and and the cpld gpio
> stuff in board-trout-gpio.c).

Thanks, I got button backlight to blink. 

> This is actually another reason why I'd actually prefer to stick with
> trout at least inside the board-dream-* files... just a lot of code
> that uses this name that's we've been working with for a year or so.
> Renaming the files is trivial and updating the config options is easy
> too, but it gets to be a lot of shuffling around to keep changing the
> names internally.  A lot of hardware has names used be the
> developers/manufacturers/etc that don't match the product names (HTC
> calls "magic" sapphire, for example, and the board files reflect
> that), and of course these devices have different names in different
> markets too.

Well, there will be more readers/users than authors... But it does not
matter that much.

Are there any issues that prevent this from being merged? Russell, can
you take those patches?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html