Re: [PATCH] kvm: remove in_range from kvm_io_device

Michael S. Tsirkin
2009-06-25T13:17:18Z

On Thu, Jun 25, 2009 at 09:02:28AM -0400, Gregory Haskins wrote:
> > Here's what I have in mind:
> > kvm does
> > lock
> > dev = find
> > unlock
> >
> > <---------- at this point group device is removed
> >
> > write access to device that has been removed
> >
> >
> >
>
> Hmm...you are right. This looks like it was introduced with that recent
> locking patch you cited. Well, I can still fix it now easily by putting
> an rcu-read-lock around the access. Longer term we should move to
> srcu. Thoughts?
>
> -Greg
>

Some callbacks take kvm mutex lock. So it seems rcu won't work,
we need srcu.

--
MST