From: Greg KH <gregkh@suse.de>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Kevin Hilman <khilman@deeprootsystems.com>,
Magnus Damm <magnus.damm@gmail.com>,
linux-kernel@vger.kernel.org, paul@pwsan.com,
stern@rowland.harvard.edu, linux-pm@lists.linux-foundation.org
Subject: Re: [PATCH] Driver Core: Add platform device arch data V3
Date: Thu, 25 Jun 2009 08:30:35 -0700 [thread overview]
Message-ID: <20090625153035.GA21920@suse.de> (raw)
In-Reply-To: <200906251635.44787.rjw@sisk.pl>
On Thu, Jun 25, 2009 at 04:35:43PM +0200, Rafael J. Wysocki wrote:
> On Thursday 18 June 2009, Kevin Hilman wrote:
> > Magnus Damm <magnus.damm@gmail.com> writes:
> >
> > > From: Magnus Damm <damm@igel.co.jp>
> > >
> > > Allow architecture specific data in struct platform_device V3.
> > >
> > > With this patch struct pdev_archdata is added to struct
> > > platform_device, similar to struct dev_archdata in found in
> > > struct device. Useful for architecture code that needs to
> > > keep extra data associated with each platform device.
> > >
> > > Struct pdev_archdata is different from dev.platform_data, the
> > > convention is that dev.platform_data points to driver-specific
> > > data. It may or may not be required by the driver. The format
> > > of this depends on driver but is the same across architectures.
> > >
> > > The structure pdev_archdata is a place for architecture specific
> > > data. This data is handled by architecture specific code (for
> > > example runtime PM), and since it is architecture specific it
> > > should _never_ be touched by device driver code. Exactly like
> > > struct dev_archdata but for platform devices.
> > >
> > > Signed-off-by: Magnus Damm <damm@igel.co.jp>
> >
> > Since there is no 'Feature-desired-by:' tag, I'll addd
> >
> > Acked-by: Kevin Hilman <khilman@deeprootsystems.com>
> >
> > For PM on ARM in general, and OMAP in particular we definitely need a
> > generic way to handle arch-specific data per platform_device.
>
> Greg, is this patch fine with you?
Yes:
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
thanks,
greg k-h
next prev parent reply other threads:[~2009-06-25 15:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-10 12:16 [PATCH] Driver Core: Add platform device arch data V3 Magnus Damm
2009-06-18 16:21 ` Kevin Hilman
2009-06-24 11:50 ` Magnus Damm
2009-06-24 18:50 ` Rafael J. Wysocki
2009-06-25 2:25 ` Magnus Damm
2009-06-25 14:34 ` Rafael J. Wysocki
2009-06-25 17:17 ` [linux-pm] " Paul Mundt
2009-06-25 14:35 ` Rafael J. Wysocki
2009-06-25 15:30 ` Greg KH [this message]
2009-07-04 23:44 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090625153035.GA21920@suse.de \
--to=gregkh@suse.de \
--cc=khilman@deeprootsystems.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=magnus.damm@gmail.com \
--cc=paul@pwsan.com \
--cc=rjw@sisk.pl \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox