From: Sam Ravnborg <sam@ravnborg.org>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Bug in arch/x86/include/asm/boot.h [Was: next cleanup report: "bad" references to CONFIG variables]
Date: Thu, 25 Jun 2009 21:24:12 +0200 [thread overview]
Message-ID: <20090625192412.GA15823@uranus.ravnborg.org> (raw)
In-Reply-To: <alpine.LFD.2.00.0906251028270.24694@localhost>
On Thu, Jun 25, 2009 at 10:34:05AM -0400, Robert P. J. Day wrote:
>
> here's the next cleanup report that's well underway -- "bad"
> references to CONFIG variables that don't exist in any Kconfig file:
>
> http://www.crashcourse.ca/wiki/index.php/Badref_CONFIG_variables
>
> (currently, only the arch/ and drivers/ directories have been updated
> -- the rest should be done shortly.)
>
> in a nutshell, that's a list of references to variables of the form
> CONFIG_*, where there is no such variable defined anywhere in a
> Kconfig file. some possible reasons for that:
>
> 1) leftover historical cruft
> 2) simple typo
> 3) someone's added code without adding the Kconfig infrastructure
> for it (annoyingly, there appears to be quite a lot of that)
> 4) someone likes to name their macros with a "CONFIG_" prefix just
> to pollute the Kconfig namespace (argh)
>
Care to send a patch to fix the one in arch/x86/include/asm/boot.h?
> in any event, it's all there (some of it starting to look awfully
> familiar as the years go by).
> as always, ignore the false positives.
If you continue this then please filter the know false positives.
For once start ignoring defconfigs.
Sam
next prev parent reply other threads:[~2009-06-25 19:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-25 14:34 next cleanup report: "bad" references to CONFIG variables Robert P. J. Day
2009-06-25 19:24 ` Sam Ravnborg [this message]
2009-06-25 19:27 ` Bug in arch/x86/include/asm/boot.h [Was: next cleanup report: "bad" references to CONFIG variables] Robert P. J. Day
2009-06-25 20:44 ` Sam Ravnborg
2009-06-25 21:43 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090625192412.GA15823@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rpjday@crashcourse.ca \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox