From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Daniel Ribeiro <drwyrm@gmail.com>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
linux-kernel <linux-kernel@vger.kernel.org>,
openezx-devel <openezx-devel@lists.openezx.org>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH] PCAP regulator driver (for 2.6.32).
Date: Fri, 26 Jun 2009 00:37:24 +0100 [thread overview]
Message-ID: <20090625233723.GA13150@sirena.org.uk> (raw)
In-Reply-To: <1245961793.10360.26.camel@brutus>
On Thu, Jun 25, 2009 at 05:29:53PM -0300, Daniel Ribeiro wrote:
> + /*
> + * The regulator framework doesn't like regulators which default
> + * to ON at boot time, so we just disable it here (when it is safe).
> + */
> + if (pdev->id == VAUX2 || pdev->id == VAUX3)
> + pcap_regulator_disable(rdev);
No need to do this - the regulator framework is perfectly happy with
regulators that are enabled at boot time and turning regulators that are
actively being used off is likely to cause issues. Regulator drivers
should just leave everything as they find it and leave it up to the core
and machine drivers to make any changes.
Other than that this looks good; I'm assuming the PCAP core has a
sensible way of getting the platform data to the devices.
next prev parent reply other threads:[~2009-06-25 23:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-25 20:29 [PATCH] PCAP regulator driver (for 2.6.32) Daniel Ribeiro
2009-06-25 23:37 ` Mark Brown [this message]
2009-06-26 6:04 ` Daniel Ribeiro
2009-06-26 10:55 ` Mark Brown
2009-06-26 12:26 ` Daniel Ribeiro
2009-06-26 15:08 ` Mark Brown
2009-06-26 22:26 ` Daniel Ribeiro
2009-06-27 0:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090625233723.GA13150@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=drwyrm@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=openezx-devel@lists.openezx.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox