From: Johannes Weiner <hannes@cmpxchg.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: akpm@linux-foundation.org, mm-commits@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: mmotm 2009-06-25-15-49 uploaded
Date: Fri, 26 Jun 2009 05:02:28 +0200 [thread overview]
Message-ID: <20090626030228.GA9279@cmpxchg.org> (raw)
In-Reply-To: <4A440D59.50400@oracle.com>
On Thu, Jun 25, 2009 at 04:50:49PM -0700, Randy Dunlap wrote:
> akpm@linux-foundation.org wrote:
> > The mm-of-the-moment snapshot 2009-06-25-15-49 has been uploaded to
> >
> > http://userweb.kernel.org/~akpm/mmotm/
> >
> > and will soon be available at
> >
> > git://git.zen-sources.org/zen/mmotm.git
>
>
> shrink_slab-handle-bad-shrinkers.patch:
>
> mm/vmscan.c: In function 'do_try_to_free_pages':
> mm/vmscan.c:1697: error: too few arguments to function 'disable_swap_token'
> mm/vmscan.c: In function 'balance_pgdat':
> mm/vmscan.c:1869: error: too few arguments to function 'disable_swap_token'
> mm/vmscan.c: In function '__zone_reclaim':
> mm/vmscan.c:2425: error: too few arguments to function 'disable_swap_token'
Sorry, my fault - `make CONFIG_SWAP=n` didn't work as I assumed. The
patch Randy pointed out seems unrelated to this, though...?
---
From: Johannes Weiner <hannes@cmpxchg.org>
Subject: mm: make swap token dummies static inlines fix
disable_swap_token() doesn't take an argument. This fixes the
!CONFIG_SWAP dummy.
Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
---
diff --git a/include/linux/swap.h b/include/linux/swap.h
index 9b02f33..6c990e6 100644
--- a/include/linux/swap.h
+++ b/include/linux/swap.h
@@ -432,7 +432,7 @@ static inline int has_swap_token(struct mm_struct *mm)
return 0;
}
-static inline void disable_swap_token(struct mm_struct *mm)
+static inline void disable_swap_token(void)
{
}
next prev parent reply other threads:[~2009-06-26 3:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-25 22:49 mmotm 2009-06-25-15-49 uploaded akpm
2009-06-25 23:50 ` Randy Dunlap
2009-06-26 0:20 ` Andrew Morton
2009-06-26 3:02 ` Johannes Weiner [this message]
2009-06-26 15:36 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090626030228.GA9279@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox