public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alex Chiang <achiang@hp.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Alex Riesen <raa.lkml@gmail.com>,
	lenb@kernel.org, twmoure@szypr.net, alessandro.suardi@gmail.com,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Thomas Renninger <trenn@suse.de>,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH v3 11/12] ACPI: video: convert to acpi_get_pci_dev
Date: Fri, 26 Jun 2009 13:28:17 -0600	[thread overview]
Message-ID: <20090626192817.GD16840@ldl.fc.hp.com> (raw)
In-Reply-To: <20090626121926.12fccba0@jbarnes-g45>

* Jesse Barnes <jbarnes@virtuousgeek.org>:
> 
> Here's the output from my machine, including ACPI paths (summary of not
> found stuff at the top):
> 
> ...
> [    0.177188] + Adding \_SB_.PCI0.AGP_
> [    0.177294] pci_bus 0000:00: I'm a little pci_bus, short and stout...
> [    0.177407] Searching for 0000:00:01.0...not found
> ...
> [    0.179259] + Adding \_SB_.PCI0.EXP2
> [    0.179364] pci_bus 0000:00: I'm a little pci_bus, short and stout...
> [    0.179477] Searching for 0000:00:1c.2...not found
> ...
> [    0.180128] ACPI: PCI Interrupt Routing Table [\_SB_.PCI0.EXP3._PRT]
> [    0.180200] Starting root bridge search from \_SB_.PCI0.EXP3.EXUP
> [    0.180310] + Adding \_SB_.PCI0.EXP3.EXUP
> [    0.180418] + Adding \_SB_.PCI0.EXP3
> [    0.180523] pci_bus 0000:00: I'm a little pci_bus, short and stout...
> [    0.180636] Searching for 0000:00:1c.3...found
> [    0.180787] Searching for 0000:05:00.0...not found
> ...
> 
> So looks like one is an express slot, another is the AGP this machine
> lacks, and then there's this 05:00.0; not sure what that is.
> 
> At any rate, it does appear we have to take care not to assume
> *everything* in the ACPI tree has an associated PCI dev, since
> namespaces could be shared accross different platforms with just enable
> or present bits to mask them out from the initial PCI scan.

Yup, as per our irc discussion, I'm now a lot more confident that
this was the root cause.

Troy's original patch is correct, just needs an explanation of
_why_. :)

I'll send a patch updating acpi_get_pci_dev() with a comment that
explains the "why".

Thanks everyone.

/ac


  reply	other threads:[~2009-06-26 19:28 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-10 19:55 [PATCH v3 00/12] Dynamic ACPI-PCI binding Alex Chiang
2009-06-10 19:55 ` [PATCH v3 01/12] ACPI: make acpi_pci_bind() static Alex Chiang
2009-06-10 19:55 ` [PATCH v3 02/12] ACPI: Introduce acpi_is_root_bridge() Alex Chiang
2009-06-10 19:55 ` [PATCH v3 03/12] ACPI: Introduce acpi_get_pci_dev() Alex Chiang
2009-06-10 19:55 ` [PATCH v3 04/12] ACPI: rearrange acpi_pci_bind/acpi_pci_unbind in pci_bind.c Alex Chiang
2009-06-10 19:55 ` [PATCH v3 05/12] ACPI: eviscerate pci_bind.c Alex Chiang
2009-06-10 19:55 ` [PATCH v3 06/12] ACPI: simplify acpi_pci_irq_add_prt() API Alex Chiang
2009-06-10 19:55 ` [PATCH v3 07/12] ACPI: simplify acpi_pci_irq_del_prt() API Alex Chiang
2009-06-10 19:55 ` [PATCH v3 08/12] ACPI: acpi_pci_unbind should clean up properly after acpi_pci_bind Alex Chiang
2009-06-10 19:55 ` [PATCH v3 09/12] PCI Hotplug: acpiphp: convert to acpi_get_pci_dev Alex Chiang
2009-06-10 19:55 ` [PATCH v3 10/12] ACPI: kill acpi_get_pci_id Alex Chiang
2009-06-10 19:56 ` [PATCH v3 11/12] ACPI: video: convert to acpi_get_pci_dev Alex Chiang
2009-06-25 22:38   ` Alex Riesen
2009-06-25 23:05     ` Alex Chiang
2009-06-26  6:43       ` Troy Moure
2009-06-26 10:56       ` Alex Riesen
2009-06-26 12:28         ` Alex Riesen
2009-06-26 19:19           ` Jesse Barnes
2009-06-26 19:28             ` Alex Chiang [this message]
2009-06-10 19:56 ` [PATCH v3 12/12] ACPI: kill acpi_get_physical_pci_device() Alex Chiang
2009-06-11 19:22 ` [PATCH v3 00/12] Dynamic ACPI-PCI binding Bjorn Helgaas
2009-06-18  3:36   ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090626192817.GD16840@ldl.fc.hp.com \
    --to=achiang@hp.com \
    --cc=alessandro.suardi@gmail.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=raa.lkml@gmail.com \
    --cc=trenn@suse.de \
    --cc=twmoure@szypr.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox