From: Frans Pop <elendil@planet.nl>
To: linux-acpi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Len Brown <len.brown@intel.com>
Subject: [PATCH] acpi processor: simplify needlessly complex printk
Date: Sun, 28 Jun 2009 22:03:54 +0200 [thread overview]
Message-ID: <200906282203.55643.elendil@planet.nl> (raw)
Why use three printk statements if one will do?
Signed-off-by: Frans Pop <elendil@planet.nl>
diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
index 84e0f3c..b8fb74a 100644
--- a/drivers/acpi/processor_core.c
+++ b/drivers/acpi/processor_core.c
@@ -772,12 +772,11 @@ static int __cpuinit acpi_processor_start(struct acpi_device *device)
if (result)
printk(KERN_ERR PREFIX "Create sysfs link\n");
- if (pr->flags.throttling) {
- printk(KERN_INFO PREFIX "%s [%s] (supports",
- acpi_device_name(device), acpi_device_bid(device));
- printk(" %d throttling states", pr->throttling.state_count);
- printk(")\n");
- }
+ if (pr->flags.throttling)
+ printk(KERN_INFO PREFIX
+ "%s [%s] (supports %d throttling states)\n",
+ acpi_device_name(device), acpi_device_bid(device),
+ pr->throttling.state_count);
end:
next reply other threads:[~2009-06-28 20:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-28 20:03 Frans Pop [this message]
2009-06-28 22:02 ` [PATCH] acpi processor: simplify needlessly complex printk Justin P. Mattock
2009-06-28 22:28 ` Frans Pop
2009-06-28 22:51 ` Justin P. Mattock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906282203.55643.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox