public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frans Pop <elendil@planet.nl>
To: "Justin P. Mattock" <justinmattock@gmail.com>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Len Brown <len.brown@intel.com>
Subject: Re: [PATCH] acpi processor: simplify needlessly complex printk
Date: Mon, 29 Jun 2009 00:28:32 +0200	[thread overview]
Message-ID: <200906290028.33285.elendil@planet.nl> (raw)
In-Reply-To: <4A47E85D.3020202@gmail.com>

On Monday 29 June 2009, Justin P. Mattock wrote:
> Would it be better to capitalize the S and add a period at the
> end, or does it not matter?

Kernel messages are in general not sentences.

I thought of removing the parenteses, but if you look at the context of 
the message then that only makes sense if other messages are modified at 
the same time. The messages below appear together for my system and their 
consistency could definitely be improved, but IMO that's better done in a 
separate patch.

ACPI: CPU0 (power states: C1[C1] C2[C2] C3[C3])
processor LNXCPU:00: registered as cooling_device7
ACPI: Processor [CPU0] (supports 8 throttling states)

  reply	other threads:[~2009-06-28 22:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-28 20:03 [PATCH] acpi processor: simplify needlessly complex printk Frans Pop
2009-06-28 22:02 ` Justin P. Mattock
2009-06-28 22:28   ` Frans Pop [this message]
2009-06-28 22:51     ` Justin P. Mattock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906290028.33285.elendil@planet.nl \
    --to=elendil@planet.nl \
    --cc=justinmattock@gmail.com \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox