From: Ingo Molnar <mingo@elte.hu>
To: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>, linux-kernel@vger.kernel.org
Subject: Re: performance counter ~0.4% error finding retired instruction count
Date: Mon, 29 Jun 2009 05:48:40 +0200 [thread overview]
Message-ID: <20090629034840.GB8059@elte.hu> (raw)
In-Reply-To: <19016.8971.391008.394778@cargo.ozlabs.ibm.com>
* Paul Mackerras <paulus@samba.org> wrote:
> I can think of three ways to eliminate the PLT resolver overhead on
> execvp:
>
> (1) Do execvp on a non-executable file first to get execvp resolved:
>
> char tmpnam[16];
> int fd;
> char *args[1];
>
> strcpy(tmpname, "/tmp/perfXXXXXX");
> fd = mkstemp(tmpname);
> if (fd >= 0) {
> args[1] = NULL;
> execvp(tmpname, args);
> close(fd);
> unlink(tmpname);
> }
> enable_counters();
> execvp(prog, argv);
>
> (2) Look up execvp in glibc and call it directly:
>
> int (*execptr)(const char *, char *const []);
>
> execptr = dlsym(RTLD_NEXT, "execvp");
> enable_counters();
> (*execptr)(prog, argv);
>
> (3) Resolve the executable path ourselves and then invoke the execve
> system call directly:
>
> char *execpath;
>
> execpath = search_path(getenv("PATH"), prog);
> enable_counters();
> syscall(NR_execve, execpath, argv, envp);
>
> (4) Same as (1), but rely on "" being an invalid program name for
> execvp:
>
> execvp("", argv);
> enable_counters();
> execvp(prog, argv);
>
> What do you guys think? Does any of these appeal more than the
> others? I'm leaning towards (4) myself.
(4) looks convincingly elegant.
We could also do (5): a one-shot counters-disabled ptrace run of the
target, then enable-counters-in-target + ptrace-detach after the
first stop.
Ingo
prev parent reply other threads:[~2009-06-29 3:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-24 13:59 performance counter 20% error finding retired instruction count Vince Weaver
2009-06-24 15:10 ` Ingo Molnar
2009-06-25 2:12 ` Vince Weaver
2009-06-25 6:50 ` Peter Zijlstra
2009-06-25 9:13 ` Ingo Molnar
2009-06-26 18:22 ` Vince Weaver
2009-06-26 19:12 ` Peter Zijlstra
2009-06-27 5:32 ` Ingo Molnar
2009-06-26 19:23 ` Vince Weaver
2009-06-27 6:04 ` performance counter ~0.4% " Ingo Molnar
2009-06-27 6:44 ` [numbers] perfmon/pfmon overhead of 17%-94% Ingo Molnar
2009-06-29 18:25 ` Vince Weaver
2009-06-29 21:02 ` Ingo Molnar
2009-07-02 21:07 ` Vince Weaver
2009-07-03 7:58 ` Ingo Molnar
2009-07-03 21:43 ` Vince Weaver
2009-07-03 18:31 ` Andi Kleen
2009-07-03 21:25 ` Vince Weaver
2009-07-03 23:40 ` Andi Kleen
2009-06-29 23:46 ` [patch] perf_counter: Add enable-on-exec attribute Ingo Molnar
2009-06-29 23:55 ` [numbers] perfmon/pfmon overhead of 17%-94% Ingo Molnar
2009-06-30 0:05 ` Ingo Molnar
2009-06-27 6:48 ` performance counter ~0.4% error finding retired instruction count Paul Mackerras
2009-06-27 17:28 ` Ingo Molnar
2009-06-29 2:12 ` Paul Mackerras
2009-06-29 2:13 ` Paul Mackerras
2009-06-29 3:48 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090629034840.GB8059@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox