From: Feng Tang <feng.tang@intel.com>
To: "Pan, Jacob jun" <jacob.jun.pan@intel.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@linux.intel.com>,
"Brown, Len" <len.brown@intel.com>
Subject: Re: [PATCH 9/9] x86/apic: support moorestown interrupt subsystem
Date: Mon, 29 Jun 2009 10:59:33 +0800 [thread overview]
Message-ID: <20090629105933.56c6336f@feng-desktop> (raw)
In-Reply-To: <43F901BD926A4E43B106BF17856F0755641A44CB@orsmsx508.amr.corp.intel.com>
On Sat, 27 Jun 2009 01:18:50 +0800
"Pan, Jacob jun" <jacob.jun.pan@intel.com> wrote:
> >> -#ifdef CONFIG_ACPI
> >> +#if defined(CONFIG_ACPI) || defined(CONFIG_SFI)
> >
> >Please add a new helper non-interactive Kconfig symbol instead of
> >increasing the #ifdef jungle.
> >
> [[JPAN]] I agreed, maybe this should be part of the SFI patch or
> already have similar plans?
Yes, Ingo has given similar comments for SFI code. I thought about 2
methods for this:
1. these "#ifdef...#endif" covers three functions:
extern int io_apic_get_unique_id(int ioapic, int apic_id);
extern int io_apic_get_version(int ioapic);
extern int io_apic_get_redir_entries(int ioapic);
how about just completely removing the "#ifdef...#endif", as ACPI/SFI
codes are heavily used on x86 platforms, and it may bring one hundred
additional bytes for None-ACPI/SFI platforms
2. create a new "CONFIG_ACPI_SFI" option, using this new option to cover
this case, and let "ACPI"/"SFI" option select it in Kconfig files
any comments? thanks
- Feng
next prev parent reply other threads:[~2009-06-29 3:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-26 0:15 [PATCH 9/9] x86/apic: support moorestown interrupt subsystem Pan, Jacob jun
2009-06-26 7:07 ` Ingo Molnar
2009-06-26 13:48 ` Pan, Jacob jun
2009-06-26 17:18 ` Pan, Jacob jun
2009-06-29 2:59 ` Feng Tang [this message]
2009-06-29 16:10 ` Len Brown
2009-06-29 16:35 ` Len Brown
2009-06-26 19:41 ` Eric W. Biederman
2009-06-26 23:24 ` Pan, Jacob jun
2009-06-26 23:46 ` Eric W. Biederman
2009-06-29 18:57 ` Pan, Jacob jun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090629105933.56c6336f@feng-desktop \
--to=feng.tang@intel.com \
--cc=hpa@linux.intel.com \
--cc=jacob.jun.pan@intel.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox