* [PATCH] tracing/syscall: remove redundant code
@ 2009-06-29 9:16 Xiao Guangrong
2009-06-29 11:13 ` Frederic Weisbecker
0 siblings, 1 reply; 2+ messages in thread
From: Xiao Guangrong @ 2009-06-29 9:16 UTC (permalink / raw)
To: Ingo; +Cc: Frederic Weisbecker, Steven Rostedt, LKML
No need to call trace_wake_up() explicitly because it's called
in trace_current_buffer_unlock_commit().
Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
---
kernel/trace/trace_syscalls.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c
index 5e57964..dd1ce2c 100644
--- a/kernel/trace/trace_syscalls.c
+++ b/kernel/trace/trace_syscalls.c
@@ -168,7 +168,6 @@ void ftrace_syscall_enter(struct pt_regs *regs)
syscall_get_arguments(current, regs, 0, sys_data->nb_args, entry->args);
trace_current_buffer_unlock_commit(event, 0, 0);
- trace_wake_up();
}
void ftrace_syscall_exit(struct pt_regs *regs)
@@ -194,7 +193,6 @@ void ftrace_syscall_exit(struct pt_regs *regs)
entry->ret = syscall_get_return_value(current, regs);
trace_current_buffer_unlock_commit(event, 0, 0);
- trace_wake_up();
}
static int init_syscall_tracer(struct trace_array *tr)
--
1.6.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tracing/syscall: remove redundant code
2009-06-29 9:16 [PATCH] tracing/syscall: remove redundant code Xiao Guangrong
@ 2009-06-29 11:13 ` Frederic Weisbecker
0 siblings, 0 replies; 2+ messages in thread
From: Frederic Weisbecker @ 2009-06-29 11:13 UTC (permalink / raw)
To: Xiao Guangrong; +Cc: Ingo, Steven Rostedt, LKML
On Mon, Jun 29, 2009 at 05:16:23PM +0800, Xiao Guangrong wrote:
> No need to call trace_wake_up() explicitly because it's called
> in trace_current_buffer_unlock_commit().
>
> Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
> ---
> kernel/trace/trace_syscalls.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c
> index 5e57964..dd1ce2c 100644
> --- a/kernel/trace/trace_syscalls.c
> +++ b/kernel/trace/trace_syscalls.c
> @@ -168,7 +168,6 @@ void ftrace_syscall_enter(struct pt_regs *regs)
> syscall_get_arguments(current, regs, 0, sys_data->nb_args, entry->args);
>
> trace_current_buffer_unlock_commit(event, 0, 0);
> - trace_wake_up();
> }
>
> void ftrace_syscall_exit(struct pt_regs *regs)
> @@ -194,7 +193,6 @@ void ftrace_syscall_exit(struct pt_regs *regs)
> entry->ret = syscall_get_return_value(current, regs);
>
> trace_current_buffer_unlock_commit(event, 0, 0);
> - trace_wake_up();
> }
>
> static int init_syscall_tracer(struct trace_array *tr)
> --
> 1.6.1.2
>
Thanks,
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-29 11:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-29 9:16 [PATCH] tracing/syscall: remove redundant code Xiao Guangrong
2009-06-29 11:13 ` Frederic Weisbecker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox