From: Matthew Wilcox <matthew@wil.cx>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Grant Grundler <grundler@parisc-linux.org>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [BUG 2.6.31-rc1] HIGHMEM64G causes hang in PCI init on 32-bit x86
Date: Mon, 29 Jun 2009 05:21:55 -0600 [thread overview]
Message-ID: <20090629112155.GJ5480@parisc-linux.org> (raw)
In-Reply-To: <19016.41349.636663.515540@pilspetsen.it.uu.se>
On Mon, Jun 29, 2009 at 01:12:05PM +0200, Mikael Pettersson wrote:
> H. Peter Anvin writes:
> > Grant Grundler wrote:
> > > On Sat, Jun 27, 2009 at 11:45:24AM +0200, Mikael Pettersson wrote:
> > > ...
> > >> fff00000-fffffffe : pnp 00:09
> > >> 100000000-1ffffffff : System RAM
> > >> 200000000-ffffffffffffffff : RAM buffer
> > >>
> > >> With 2.6.30 things look similar, except 2.6.30 does not show the
> > >> last "200000000-ffffffffffffffff : RAM buffer" line.
> > >
> > > BIOS e280 table didn't report that line.
> > > I expect it's created by arch/x86/kernel/e820.c:
> > > 1398 /*
> > > 1399 * Try to bump up RAM regions to reasonable boundaries to
> > > 1400 * avoid stolen RAM:
> > > 1401 */
> > > 1402 for (i = 0; i < e820.nr_map; i++) {
> > > 1403 struct e820entry *entry = &e820_saved.map[i];
> > > 1404 resource_size_t start, end;
> > > 1405
> > > 1406 if (entry->type != E820_RAM)
> > > 1407 continue;
> > > 1408 start = entry->addr + entry->size;
> > > 1409 end = round_up(start, ram_alignment(start));
> > > 1410 if (start == end)
> > > 1411 continue;
> > > 1412 reserve_region_with_split(&iomem_resource, start,
> > > 1413 end - 1, "RAM buffer");
> > > 1414 }
> > >
> >
> > OK, this seems more than a wee bit strange, to say the least. We
> > shouldn't be reserving the entire address space; this is legitimate I/O
> > space.
> >
> > However, the reservation suddenly being improper for the root resource
> > would definitely make things unhappy...
>
> Reverting the two e820 changes in 2.6.31-rc1,
> 5d423ccd7ba4285f1084e91b26805e1d0ae978ed and then
> 45fbe3ee01b8e463b28c2751b5dcc0cbdc142d90,
> but keeping the iomem_resource.end cap change, makes 2.6.31-rc1
> work on my HIGHMEM64G machine.
>
> Seems the e820 and the iomem_resource.end changes are Ok in
> isolation but break when combined.
With the e820 change reverted, what does /proc/iomem look like?
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2009-06-29 11:22 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-26 15:59 [BUG 2.6.31-rc1] HIGHMEM64G causes hang in PCI init on 32-bit x86 Mikael Pettersson
2009-06-27 1:13 ` Mikael Pettersson
2009-06-27 4:25 ` Grant Grundler
2009-06-27 5:31 ` H. Peter Anvin
2009-06-29 2:24 ` Grant Grundler
2009-06-27 9:42 ` Mikael Pettersson
2009-06-27 19:27 ` H. Peter Anvin
2009-06-27 21:34 ` Mikael Pettersson
2009-06-27 4:53 ` H. Peter Anvin
2009-06-27 9:45 ` Mikael Pettersson
2009-06-29 2:29 ` Grant Grundler
2009-06-29 5:00 ` H. Peter Anvin
2009-06-29 11:12 ` Mikael Pettersson
2009-06-29 11:21 ` Matthew Wilcox [this message]
2009-06-29 11:57 ` Mikael Pettersson
2009-06-29 18:29 ` H. Peter Anvin
2009-06-29 22:47 ` Yinghai Lu
2009-06-29 23:29 ` Yinghai Lu
2009-06-30 0:27 ` H. Peter Anvin
2009-06-30 1:14 ` Yinghai Lu
2009-06-30 1:18 ` H. Peter Anvin
2009-06-30 1:24 ` Yinghai Lu
2009-06-30 2:41 ` H. Peter Anvin
2009-06-30 1:26 ` Linus Torvalds
2009-06-30 1:41 ` Yinghai Lu
2009-06-30 8:45 ` Mikael Pettersson
2009-06-30 14:48 ` H. Peter Anvin
2009-06-30 15:00 ` Rolf Eike Beer
2009-06-30 18:52 ` H. Peter Anvin
2009-06-30 19:33 ` Yinghai Lu
2009-06-30 19:44 ` H. Peter Anvin
2009-06-30 20:05 ` Yinghai Lu
2009-06-30 21:21 ` H. Peter Anvin
2009-06-30 21:50 ` Yinghai Lu
2009-06-30 22:10 ` Linus Torvalds
2009-06-30 22:30 ` Yinghai Lu
2009-06-30 22:51 ` Yinghai Lu
2009-06-30 22:54 ` H. Peter Anvin
2009-06-30 23:00 ` Linus Torvalds
2009-06-30 23:04 ` Linus Torvalds
2009-06-30 23:13 ` Yinghai Lu
2009-06-30 23:19 ` H. Peter Anvin
2009-07-01 19:32 ` [PATCH] x86: add boundary check for 32bit res before expand e820 resource to alignment Yinghai Lu
2009-07-01 19:33 ` [PATCH] fix round_up/down Yinghai Lu
2009-07-01 19:39 ` Joe Perches
2009-07-01 20:02 ` Andrew Morton
2009-07-02 18:10 ` [PATCH] x86: add boundary check for 32bit res before expand e820 resource to alignment -v2 Yinghai Lu
2009-07-03 8:05 ` Ingo Molnar
2009-06-30 23:16 ` [BUG 2.6.31-rc1] HIGHMEM64G causes hang in PCI init on 32-bit x86 H. Peter Anvin
2009-06-30 20:10 ` Linus Torvalds
2009-06-30 1:44 ` H. Peter Anvin
2009-06-30 0:22 ` H. Peter Anvin
2009-06-27 19:33 ` [tip:x86/urgent] Revert "x86: cap iomem_resource to addressable physical memory" tip-bot for H. Peter Anvin
2009-06-27 21:49 ` Mikael Pettersson
2009-06-27 22:04 ` tip-bot for H. Peter Anvin
2009-06-28 7:39 ` tip-bot for H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090629112155.GJ5480@parisc-linux.org \
--to=matthew@wil.cx \
--cc=grundler@parisc-linux.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mikpe@it.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox