Move of_node_to_nid to generic location

Move of_node_to_nid to generic location

[Michal Simek]

Hi All,

I have on my list one task which needs to be discuss with you.
I look at of_node_to_nid for non NUMA systems. I think we should
move this function to asm-generic/topology.h.

This function is used for powerpc, sparc, microblaze (and maybe future arm?)

Arnd what do you think?

Michal

-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854

Re: Move of_node_to_nid to generic location

[Grant Likely]

On Mon, Jun 29, 2009 at 3:09 AM, Michal Simek<monstr@monstr.eu> wrote:
> Hi All,
>
> I have on my list one task which needs to be discuss with you.
> I look at of_node_to_nid for non NUMA systems. I think we should
> move this function to asm-generic/topology.h.

I'm in the process of moving a bunch of stuff out of the various
prom.c files and into drivers/of/*.c.  If this is a common function,
then I think it should go there.

> This function is used for powerpc, sparc, microblaze (and maybe future arm?)

PowerPC uses it.  Other than that I don't know.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

Re: Move of_node_to_nid to generic location

[Arnd Bergmann]

On Monday 29 June 2009, Grant Likely wrote:
> On Mon, Jun 29, 2009 at 3:09 AM, Michal Simek<monstr@monstr.eu> wrote:
> > Hi All,
> >
> > I have on my list one task which needs to be discuss with you.
> > I look at of_node_to_nid for non NUMA systems. I think we should
> > move this function to asm-generic/topology.h.
> 
> I'm in the process of moving a bunch of stuff out of the various
> prom.c files and into drivers/of/*.c.  If this is a common function,
> then I think it should go there.

I agree, it fits better into one of the 'of' headers than the topology
header. Maybe include/linux/of_device.h or include/linux/of.h?

	Arnd <><

Re: Move of_node_to_nid to generic location

[David Miller]

From: Grant Likely <grant.likely@secretlab.ca>
Date: Mon, 29 Jun 2009 09:52:44 -0600

> On Mon, Jun 29, 2009 at 3:09 AM, Michal Simek<monstr@monstr.eu> wrote:
>> This function is used for powerpc, sparc, microblaze (and maybe future arm?)
> 
> PowerPC uses it.  Other than that I don't know.

Sparc64 definitely uses it.

Re: Move of_node_to_nid to generic location

[Michal Simek]

David Miller wrote:
> From: Grant Likely <grant.likely@secretlab.ca>
> Date: Mon, 29 Jun 2009 09:52:44 -0600
> 
>> On Mon, Jun 29, 2009 at 3:09 AM, Michal Simek<monstr@monstr.eu> wrote:
>>> This function is used for powerpc, sparc, microblaze (and maybe future arm?)
>> PowerPC uses it.  Other than that I don't know.
> 
> Sparc64 definitely uses it.

of_node_nid is called from of_device_register function and could be used by all "fdt" arch.
Anyway I think that we found a solution for it.
Grant can you please incorporate this changes to your patches (just move implementation for non NUMA
systems)?
IMHO of_device.h is the best one.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854