From: Pavel Machek <pavel@ucw.cz>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, pierre@ossman.eu,
swetland@google.com, Andrew Morton <akpm@linux-foundation.org>,
San Mehat <san@google.com>
Subject: Re: [PATCH 0/3] msm_sdcc: A few more cleanups
Date: Tue, 30 Jun 2009 08:57:48 +0200 [thread overview]
Message-ID: <20090630065747.GA19260@elf.ucw.cz> (raw)
In-Reply-To: <cover.1246319479.git.joe@perches.com>
Hi!
> Perhaps these are appropriate as well.
> Uncompiled, I haven't set up an ARM cross compiler yet.
>
> Signed-off-by: Joe Perches <joe@perches.com>
>
> Joe Perches (3):
> msm_sdcc.c: Convert printk(KERN_<level> to pr_<level>(
> msm_sdcc.c: stylistic cleaning
> msm_sdcc.c: Move overly indented code to separate function
They look good, but break compilation. With these fixes, it compiles &
boots. Thanks!
Signed-off-by: Pavel Machek <pavel@ucw.cz>
diff --git a/drivers/mmc/host/msm_sdcc.c b/drivers/mmc/host/msm_sdcc.c
index 010f4f4..6644cda 100644
--- a/drivers/mmc/host/msm_sdcc.c
+++ b/drivers/mmc/host/msm_sdcc.c
@@ -321,7 +321,7 @@ msmsdcc_start_data(struct msmsdcc_host *host, struct mmc_data *data)
memset(&host->pio, 0, sizeof(host->pio));
clks = (unsigned long long)data->timeout_ns * host->clk_rate;
- do_div(clks, NSECS_PER_SEC);
+ do_div(clks, NSEC_PER_SEC);
timeout = data->timeout_clks + (unsigned int)clks;
writel(timeout, base + MMCIDATATIMER);
@@ -588,6 +588,8 @@ static void
msmsdcc_handle_irq_data(struct msmsdcc_host *host, struct mmc_data *data,
u32 status)
{
+ void __iomem *base = host->base;
+
/* Check for data errors */
if (status & (MCI_DATACRCFAIL | MCI_DATATIMEOUT |
MCI_TXUNDERRUN | MCI_RXOVERRUN)) {
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2009-06-30 6:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-29 21:41 MMC driver for HTC Dream Pavel Machek
2009-06-29 21:46 ` Brian Swetland
2009-06-29 22:16 ` Pavel Machek
2009-06-30 0:02 ` [PATCH 0/3] msm_sdcc: A few more cleanups Joe Perches
2009-06-30 0:02 ` [PATCH 1/3] msm_sdcc.c: Convert printk(KERN_<level> to pr_<level>( Joe Perches
2009-06-30 0:02 ` [PATCH 2/3] msm_sdcc.c: stylistic cleaning Joe Perches
2009-06-30 0:02 ` [PATCH 3/3] msm_sdcc.c: Move overly indented code to separate function Joe Perches
2009-06-30 6:57 ` Pavel Machek [this message]
2009-06-30 12:30 ` [PATCH 0/3] msm_sdcc: A few more cleanups Joe Perches
2009-06-30 13:21 ` Pavel Machek
2009-06-30 15:31 ` [PATCH V2 0/3] msm_sdcc: cleanups Joe Perches
2009-06-30 15:31 ` [PATCH V2 1/3] msm_sdcc.c: Convert printk(KERN_<level> to pr_<level>( Joe Perches
2009-06-30 15:31 ` [PATCH V2 2/3] msm_sdcc.c: stylistic cleaning Joe Perches
2009-06-30 15:31 ` [PATCH V2 3/3] msm_sdcc.c: Move overly indented code to separate function Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090630065747.GA19260@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre@ossman.eu \
--cc=san@google.com \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox