From: Amerigo Wang <xiyou.wangcong@gmail.com>
To: Amerigo Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
sam@ravnborg.org
Subject: Re: [Patch] kbuild: finally remove the obsolete variable $TOPDIR
Date: Tue, 30 Jun 2009 17:06:39 +0800 [thread overview]
Message-ID: <20090630090639.GA5873@cr0.nay.redhat.com> (raw)
In-Reply-To: <20090619074241.6646.42298.sendpatchset@localhost.localdomain>
On Fri, Jun 19, 2009 at 03:40:26AM -0400, Amerigo Wang wrote:
>
>TOPDIR is obsolete, it can be finally removed now.
>
>Signed-off-by: WANG Cong <amwang@redhat.com>
>Cc: Sam <sam@ravnborg.org>
ping Sam...
>
>---
>diff --git a/Makefile b/Makefile
>index 46e1c9d..6e41628 100644
>--- a/Makefile
>+++ b/Makefile
>@@ -140,15 +140,13 @@ _all: modules
> endif
>
> srctree := $(if $(KBUILD_SRC),$(KBUILD_SRC),$(CURDIR))
>-TOPDIR := $(srctree)
>-# FIXME - TOPDIR is obsolete, use srctree/objtree
> objtree := $(CURDIR)
> src := $(srctree)
> obj := $(objtree)
>
> VPATH := $(srctree)$(if $(KBUILD_EXTMOD),:$(KBUILD_EXTMOD))
>
>-export srctree objtree VPATH TOPDIR
>+export srctree objtree VPATH
>
>
> # SUBARCH tells the usermode build what the underlying arch is. That is set
>diff --git a/drivers/scsi/cxgb3i/Kbuild b/drivers/scsi/cxgb3i/Kbuild
>index 25a2032..70d060b 100644
>--- a/drivers/scsi/cxgb3i/Kbuild
>+++ b/drivers/scsi/cxgb3i/Kbuild
>@@ -1,4 +1,4 @@
>-EXTRA_CFLAGS += -I$(TOPDIR)/drivers/net/cxgb3
>+EXTRA_CFLAGS += -I$(srctree)/drivers/net/cxgb3
>
> cxgb3i-y := cxgb3i_init.o cxgb3i_iscsi.o cxgb3i_pdu.o cxgb3i_offload.o cxgb3i_ddp.o
> obj-$(CONFIG_SCSI_CXGB3_ISCSI) += cxgb3i.o
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2009-06-30 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-19 7:40 [Patch] kbuild: finally remove the obsolete variable $TOPDIR Amerigo Wang
2009-06-30 9:06 ` Amerigo Wang [this message]
2009-06-30 9:16 ` Sam Ravnborg
2009-06-30 9:18 ` Amerigo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090630090639.GA5873@cr0.nay.redhat.com \
--to=xiyou.wangcong@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=amwang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox