Re: [PATCH 5/5] power_supply: add a charge_type status to the api, and use it for olpc driver

[Andres Salomon <dilinger@collabora.co.uk>]

On Tue, 30 Jun 2009 12:31:35 +0100
Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:

> On Tue, Jun 30, 2009 at 02:17:30AM -0400, Andres Salomon wrote:
> 
> > This adds a new sysfs file called 'charge_type' which displays the
> > type of charging (n/a, trickle charge, slow charge, or fast
> > charging).  This allows things like battery diagnostics to
> > determine what the battery/EC is doing without resorting to
> > changing the 'status' sysfs output.
> 
> > Signed-off-by: Andres Salomon <dilinger@collabora.co.uk>
> 
> This looks good to me.  Could you please keep me on the CC for any
> future revisions of this patch, I can make use of this in the WM8350
> driver.

Sure.


> 
> > +	static char *charge_type[] = {
> > +		"N/A", "Trickle", "Slow", "Fast"
> > +	};
> 
> I'd be tempted to make "N/A" be "Unknown" to match the style of the
> rest of the attributes.  I'm also not sure that we need a slow type,
> but equally it shouldn't do any harm.


It's known though, right? :)   It could just as easily be "None",
"Unknown", etc, but I'm not particularly picky.  As far as the slow
type, I don't see the need either, but I assumed Anton was aware of
devices that differentiated between slow and trickle charging.