From: Gary Hade <garyhade@us.ibm.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Yinghai Lu <yinghai@kernel.org>, Ingo Molnar <mingo@elte.hu>,
Gary Hade <garyhade@us.ibm.com>, Matthew Wilcox <matthew@wil.cx>,
"H. Peter Anvin" <hpa@zytor.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Suresh Siddha <suresh.b.siddha@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-pci@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] x86/pci: fix boundary checking when using root CRS
Date: Tue, 30 Jun 2009 11:04:49 -0700 [thread overview]
Message-ID: <20090630180449.GA7183@us.ibm.com> (raw)
In-Reply-To: <20090629181603.261ccd03@jbarnes-g45>
On Mon, Jun 29, 2009 at 06:16:03PM -0700, Jesse Barnes wrote:
> On Wed, 24 Jun 2009 19:01:19 -0700
> Yinghai Lu <yinghai@kernel.org> wrote:
>
> >
> > don't touch info->res_num if we are out of space
> >
> > Signed-off-by: Yinghai Lu <yinghai@kernel.org>
>
> Gary, any comments on these?
Jesse,
"[PATCH 1/3] x86/pci: fix boundary checking when using root CRS"
which convinced that my code was incorrect and
"[PATCH 2/3] x86/pci: get root CRS before scan childs -v3"
look good to me from both code review and functional [1] standpoints.
Acked-by: <garyhade@us.ibm.com>
Tested-by: <garyhade@us.ibm.com>
[1] Successful boot of patched 2.6.31-rc1 with pci=use_crs
followed by successful hot-add and hot-remove of PCI-X
and PCIe cards on an IBM x3850.
Thanks Yinghai.
Gary
--
Gary Hade
System x Enablement
IBM Linux Technology Center
503-578-4503 IBM T/L: 775-4503
garyhade@us.ibm.com
http://www.ibm.com/linux/ltc
next prev parent reply other threads:[~2009-06-30 18:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090624122433.GA24781@elte.hu>
[not found] ` <20090624145119.GA12664@elte.hu>
2009-06-24 21:46 ` [PATCH] x86: fix _CRS resources return handling Yinghai Lu
2009-06-24 21:48 ` [PATCH] x86/pci: get root CRS before scan child -v2 Yinghai Lu
2009-06-24 22:37 ` Jesse Barnes
2009-06-25 0:03 ` Yinghai
2009-06-24 22:58 ` [PATCH] x86/pci: don't use crs for root if we only have one root bus Yinghai Lu
2009-06-24 23:09 ` Linus Torvalds
2009-06-24 23:21 ` Linus Torvalds
2009-06-24 23:37 ` Jesse Barnes
2009-06-24 23:54 ` Linus Torvalds
2009-06-25 0:01 ` Jesse Barnes
2009-06-25 7:03 ` Ingo Molnar
2009-06-25 7:28 ` Jaswinder Singh Rajput
2009-06-25 16:28 ` Jesse Barnes
2009-06-25 0:00 ` Gary Hade
2009-06-25 2:01 ` [PATCH 1/3] x86/pci: fix boundary checking when using root CRS Yinghai Lu
2009-06-25 2:02 ` [PATCH 2/3] x86/pci: get root CRS before scan childs -v3 Yinghai Lu
2009-06-25 3:00 ` [PATCH 2/3] x86/pci: get root CRS before scan childs -v4 Yinghai Lu
2009-06-30 1:16 ` [PATCH 1/3] x86/pci: fix boundary checking when using root CRS Jesse Barnes
2009-06-30 18:04 ` Gary Hade [this message]
2009-06-30 21:00 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090630180449.GA7183@us.ibm.com \
--to=garyhade@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox