From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: "Leo (Hao) Chen" <leochen@broadcom.com>
Cc: "linux-arm-kernel@lists.arm.linux.org.uk"
<linux-arm-kernel@lists.arm.linux.org.uk>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 6/6][ARM] new ARM SoC support: BCMRing
Date: Tue, 30 Jun 2009 20:41:01 +0200 [thread overview]
Message-ID: <20090630184101.GI23292@game.jcrosoft.org> (raw)
In-Reply-To: <8628FE4E7912BF47A96AE7DD7BAC0AADCB25AE17C8@SJEXCHCCR02.corp.ad.broadcom.com>
On 16:30 Fri 26 Jun , Leo (Hao) Chen wrote:
> Hi,
>
> The last patch. This big patch includes the minimal set of our CSP (chip support package), which is our OS independent chip supporting code and headers. All the codes are under arch/arm/mach-bcmring directory.
This patch is unreadable
you need
1) Respect the Linux coding Style
2) to split in small changeset
3) use the kernel API such as clocksource, clock, dmaengine etc...
Best Regards,
J.
next prev parent reply other threads:[~2009-06-30 18:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-26 23:26 [PATCH v1 1/6][ARM] new ARM SoC support: BCMRing Leo (Hao) Chen
2009-06-26 23:28 ` [PATCH v1 2/6][ARM] " Leo (Hao) Chen
2009-06-26 23:29 ` [PATCH v1 3/6][ARM] " Leo (Hao) Chen
2009-06-26 23:30 ` [PATCH v1 4/6][ARM] " Leo (Hao) Chen
2009-06-26 23:30 ` [PATCH v1 5/6][ARM] " Leo (Hao) Chen
2009-06-26 23:30 ` [PATCH v1 6/6][ARM] " Leo (Hao) Chen
2009-06-30 18:41 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-06-30 23:20 ` Alan Cox
2009-06-30 23:37 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-30 23:54 ` Leo (Hao) Chen
2009-06-30 23:57 ` Scott Branden
2009-07-01 12:00 ` Alan Cox
2009-06-30 18:42 ` [PATCH v1 5/6][ARM] " Jean-Christophe PLAGNIOL-VILLARD
2009-06-30 18:43 ` [PATCH v1 4/6][ARM] " Jean-Christophe PLAGNIOL-VILLARD
2009-06-27 5:33 ` [PATCH v1 3/6][ARM] " Jean-Christophe PLAGNIOL-VILLARD
2009-06-30 1:09 ` Leo (Hao) Chen
2009-06-30 5:30 ` Trilok Soni
2009-06-30 21:12 ` Russell King - ARM Linux
2009-06-30 22:29 ` Alessandro Rubini
2009-06-27 5:22 ` [PATCH v1 2/6][ARM] " Jean-Christophe PLAGNIOL-VILLARD
2009-06-27 5:21 ` [PATCH v1 1/6][ARM] " Jean-Christophe PLAGNIOL-VILLARD
[not found] <8628FE4E7912BF47A96AE7DD7BAC0AADCB25AE17C3@SJEXCHCCR02.corp.ad.broa dcom.com>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090630184101.GI23292@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=leochen@broadcom.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox