From: David Brownell <david-b@pacbell.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jani Nikula <ext-jani.1.nikula@nokia.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpiolib: allow exported GPIO nodes to be named using sysfs links
Date: Tue, 30 Jun 2009 18:43:22 -0700 [thread overview]
Message-ID: <200906301843.22646.david-b@pacbell.net> (raw)
In-Reply-To: <20090622122547.bc672764.akpm@linux-foundation.org>
On Monday 22 June 2009, Andrew Morton wrote:
> On Thu, 11 Jun 2009 12:19:03 +0300
> Jani Nikula <ext-jani.1.nikula@nokia.com> wrote:
>
> > +int gpio_export_link(struct device *dev, const char *name, unsigned gpio)
> > +{
> > + struct gpio_desc *desc;
> > + int status = -EINVAL;
> > +
> > + BUG_ON(dev == NULL);
> > + BUG_ON(name == NULL);
>
> We usually don't bother with these assertions. If the kernel will
> reliably oops if one of these is NULL, then that provides the same
> information anyway.
Yeah, it'd be better to remove those BUG_ON() things before this goes upstream...
next prev parent reply other threads:[~2009-07-01 1:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-11 9:19 [PATCH] gpiolib: allow exported GPIO nodes to be named using sysfs links Jani Nikula
2009-06-22 19:25 ` Andrew Morton
2009-07-01 1:43 ` David Brownell [this message]
2009-07-01 8:01 ` [PATCH v2] " Jani Nikula
2009-07-01 8:25 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906301843.22646.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=akpm@linux-foundation.org \
--cc=ext-jani.1.nikula@nokia.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox