From: Anton Blanchard <anton@samba.org>
To: a.p.zijlstra@chello.nl, paulus@samba.org, mingo@elte.hu
Cc: linux-kernel@vger.kernel.org
Subject: [patch 8/8] powerpc: Fix PCL vdso detection
Date: Wed, 01 Jul 2009 09:00:51 +1000 [thread overview]
Message-ID: <20090630230141.407009407@samba.org> (raw)
In-Reply-To: 20090630230043.464194676@samba.org
[-- Attachment #1: pcl_fix_powerpc_vdso_detection.patch --]
[-- Type: text/plain, Size: 1336 bytes --]
PCL uses arch_vma_name() to detect a vdso region which in turn uses
current->mm->context.vdso_base. We need to initialise this before doing
the mmap or else we fail to detect the vdso.
Signed-off-by: Anton Blanchard <anton@samba.org>
---
Index: linux-2.6-tip/arch/powerpc/kernel/vdso.c
===================================================================
--- linux-2.6-tip.orig/arch/powerpc/kernel/vdso.c 2009-06-30 09:57:23.000000000 +1000
+++ linux-2.6-tip/arch/powerpc/kernel/vdso.c 2009-06-30 09:58:37.000000000 +1000
@@ -235,6 +235,13 @@
}
/*
+ * Put vDSO base into mm struct. We need to do this before calling
+ * install_special_mapping or the perf counter mmap tracking code
+ * will fail to recognise it as a vDSO (since arch_vma_name fails).
+ */
+ current->mm->context.vdso_base = vdso_base;
+
+ /*
* our vma flags don't have VM_WRITE so by default, the process isn't
* allowed to write those pages.
* gdb can break that with ptrace interface, and thus trigger COW on
@@ -254,11 +261,10 @@
VM_MAYREAD|VM_MAYWRITE|VM_MAYEXEC|
VM_ALWAYSDUMP,
vdso_pagelist);
- if (rc)
+ if (rc) {
+ current->mm->context.vdso_base = 0;
goto fail_mmapsem;
-
- /* Put vDSO base into mm struct */
- current->mm->context.vdso_base = vdso_base;
+ }
up_write(&mm->mmap_sem);
return 0;
--
next prev parent reply other threads:[~2009-06-30 23:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-30 23:00 [patch 0/8] Various PCL fixes Anton Blanchard
2009-06-30 23:00 ` [patch 1/8] perf report: Fix -z option Anton Blanchard
2009-06-30 23:27 ` [tip:perfcounters/urgent] " tip-bot for Anton Blanchard
2009-06-30 23:00 ` [patch 2/8] perf_counter tools: Remove zlib dependency Anton Blanchard
2009-06-30 23:27 ` [tip:perfcounters/urgent] " tip-bot for Anton Blanchard
2009-06-30 23:00 ` [patch 3/8] perf top: Move skip symbols to an array Anton Blanchard
2009-06-30 23:28 ` [tip:perfcounters/urgent] " tip-bot for Anton Blanchard
2009-07-01 4:31 ` [patch 3/8] " Stephen Rothwell
2009-07-01 10:50 ` Ingo Molnar
2009-06-30 23:00 ` [patch 4/8] perf top: Add ppc64 specific skip symbols and strip ppc64 . prefix Anton Blanchard
2009-06-30 23:21 ` Ingo Molnar
2009-06-30 23:26 ` Anton Blanchard
2009-06-30 23:28 ` [tip:perfcounters/urgent] " tip-bot for Anton Blanchard
2009-06-30 23:00 ` [patch 5/8] perf report: Fix reporting of hypervisor Anton Blanchard
2009-06-30 23:28 ` [tip:perfcounters/urgent] " tip-bot for Anton Blanchard
2009-06-30 23:00 ` [patch 6/8] perf report: Add hypervisor dso Anton Blanchard
2009-06-30 23:28 ` [tip:perfcounters/urgent] " tip-bot for Anton Blanchard
2009-06-30 23:00 ` [patch 7/8] powerpc: Cleanup PCL output by hiding and adding symbols Anton Blanchard
2009-06-30 23:22 ` Ingo Molnar
2009-06-30 23:00 ` Anton Blanchard [this message]
2009-06-30 23:23 ` [patch 8/8] powerpc: Fix PCL vdso detection Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090630230141.407009407@samba.org \
--to=anton@samba.org \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox