From: Greg KH <greg@kroah.com>
To: Thomas Renninger <trenn@suse.de>
Cc: Witold Szczeponik <Witold.Szczeponik@gmx.net>,
stable@kernel.org, rjw@sisk.pl, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, abelay@mit.edu,
bjorn.helgaas@hp.com
Subject: Re: [stable] [PATCH] PNPACPI: Enable PNPACPI _PSx Support, v3
Date: Tue, 30 Jun 2009 16:03:14 -0700 [thread overview]
Message-ID: <20090630230314.GD2634@kroah.com> (raw)
In-Reply-To: <200904021510.37517.trenn@suse.de>
On Thu, Apr 02, 2009 at 03:10:36PM +0200, Thomas Renninger wrote:
> Hi,
>
> I remember a bug (serial device not working)
> related to serial and docking on Lenovo.
> I wonder whether this could be related to this fix.
>
> This one also looks worth adding to stable kernel, at least
> after 2.6.30 does not show regressions for a while.
>
> On Monday 30 March 2009 19:31:06 Witold Szczeponik wrote:
> > Subject: Enable PNPACPI _PSx Support, v3
> >
> >
> > (This is an update to the patch presented earlier in
> > http://lkml.org/lkml/2008/12/8/284, with new error handling.)
> >
> > This patch sets the power of PnP ACPI devices to D0 when they
> > are activated and to D3 when they are disabled. The latter is
> > in correspondence with the ACPI 3.0 specification, whereas the
> > former is added in order to be able to power up a device after
> > it has been previously disabled (or when booting up a system).
> > (As a consequence, the patch makes the PnP ACPI code more ACPI
> > compliant.)
> >
> > Section 6.2.2 of the ACPI Specification (at least versions 1.0b
> > and 3.0a) states: "Prior to running this control method [_DIS],
> > the OS[PM] will have already put the device in the D3 state."
> > Unfortunately, there is no clear statement as to when to put
> > a device in the D0 state. :-( Therefore, the patch executes the
> > method calls as _PS3/_DIS and _SRS/_PS0. What is clear: "If the
> > device is disabled, _SRS enables the device at the specified
> > resources." (From the ACPI 3.0a Specification.)
> >
> > The patch fixes a problem with some IBM ThinkPads (at least the
> > 600E and the 600X) where the serial ports have a dedicated
> > power source that needs to be brought up before the serial port
> > can be used. Without this patch, the serial port is enabled
> > but has no power. (In the past, the tpctl utility had to be
> > utilized to turn on the power, but support for this feature
> > stopped with version 5.9 as it did not support the more recent
> > kernel versions.)
> >
> > The error handlers that handle any errors that can occur during
> > the power up/power down phases return the error codes to the
> > caller directly. Comments welcome! :-)
> >
> > No regressions were observed on hardware that does not require
> > this patch.
> >
> > The patch is applied against 2.6.27.x.
> >
> >
> > Signed-off-by: Witold Szczeponik <Witold.Szczeponik@gmx.net>
> CC: stable@kernel.org
> ...
What specific git commit id in Linus's tree is this?
thanks,
greg k-h
next prev parent reply other threads:[~2009-06-30 23:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-30 17:31 [PATCH] PNPACPI: Enable PNPACPI _PSx Support, v3 Witold Szczeponik
2009-03-31 1:45 ` yakui_zhao
2009-03-31 20:37 ` Witold Szczeponik
2009-03-31 10:19 ` Henrique de Moraes Holschuh
2009-04-04 1:32 ` Len Brown
2009-04-04 1:49 ` Len Brown
[not found] ` <200904021510.37517.trenn@suse.de>
2009-06-30 23:03 ` Greg KH [this message]
2009-07-07 20:06 ` [stable] " Witold Szczeponik
2009-07-28 19:15 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090630230314.GD2634@kroah.com \
--to=greg@kroah.com \
--cc=Witold.Szczeponik@gmx.net \
--cc=abelay@mit.edu \
--cc=bjorn.helgaas@hp.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=stable@kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox