From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, stable@kernel.org
Cc: stable-review@kernel.org, torvalds@linux-foundation.org,
akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk,
Jack Morgenstein <jackm@dev.mellanox.co.il>,
Roland Dreier <rolandd@cisco.com>
Subject: [patch 16/30] IB/mlx4: Add strong ordering to local inval and fast reg work requests
Date: Tue, 30 Jun 2009 17:00:00 -0700 [thread overview]
Message-ID: <20090701000358.828625631@mini.kroah.org> (raw)
In-Reply-To: <20090701002817.GA6156@kroah.com>
[-- Attachment #1: ib-mlx4-add-strong-ordering-to-local-inval-and-fast-reg-work-requests.patch --]
[-- Type: text/plain, Size: 1988 bytes --]
2.6.27-stable review patch. If anyone has any objections, please let us know.
------------------
From: Jack Morgenstein <jackm@dev.mellanox.co.il>
commit 2ac6bf4ddc87c3b6b609f8fa82f6ebbffeac12f4 upstream.
The ConnectX Programmer's Reference Manual states that the "SO" bit
must be set when posting Fast Register and Local Invalidate send work
requests. When this bit is set, the work request will be executed
only after all previous work requests on the send queue have been
executed. (If the bit is not set, Fast Register and Local Invalidate
WQEs may begin execution too early, which violates the defined
semantics for these operations)
This fixes the issue with NFS/RDMA reported in
<http://lists.openfabrics.org/pipermail/general/2009-April/059253.html>
Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/infiniband/hw/mlx4/qp.c | 4 ++++
include/linux/mlx4/qp.h | 1 +
2 files changed, 5 insertions(+)
--- a/drivers/infiniband/hw/mlx4/qp.c
+++ b/drivers/infiniband/hw/mlx4/qp.c
@@ -1563,12 +1563,16 @@ int mlx4_ib_post_send(struct ib_qp *ibqp
break;
case IB_WR_LOCAL_INV:
+ ctrl->srcrb_flags |=
+ cpu_to_be32(MLX4_WQE_CTRL_STRONG_ORDER);
set_local_inv_seg(wqe, wr->ex.invalidate_rkey);
wqe += sizeof (struct mlx4_wqe_local_inval_seg);
size += sizeof (struct mlx4_wqe_local_inval_seg) / 16;
break;
case IB_WR_FAST_REG_MR:
+ ctrl->srcrb_flags |=
+ cpu_to_be32(MLX4_WQE_CTRL_STRONG_ORDER);
set_fmr_seg(wqe, wr);
wqe += sizeof (struct mlx4_wqe_fmr_seg);
size += sizeof (struct mlx4_wqe_fmr_seg) / 16;
--- a/include/linux/mlx4/qp.h
+++ b/include/linux/mlx4/qp.h
@@ -165,6 +165,7 @@ enum {
MLX4_WQE_CTRL_IP_CSUM = 1 << 4,
MLX4_WQE_CTRL_TCP_UDP_CSUM = 1 << 5,
MLX4_WQE_CTRL_INS_VLAN = 1 << 6,
+ MLX4_WQE_CTRL_STRONG_ORDER = 1 << 7,
};
struct mlx4_wqe_ctrl_seg {
next prev parent reply other threads:[~2009-07-01 0:34 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090630235944.868879272@mini.kroah.org>
2009-07-01 0:28 ` [patch 00/30] 2.6.27-stable review Greg KH
2009-06-30 23:59 ` [patch 01/30] parport: netmos 9845 & 9855 1P4S fixes Greg KH
2009-06-30 23:59 ` [patch 02/30] atmel_lcdfb: correct fifo size for some products Greg KH
2009-06-30 23:59 ` [patch 03/30] bonding: fix multiple module load problem Greg KH
2009-06-30 23:59 ` [patch 04/30] char: moxa, prevent opening unavailable ports Greg KH
2009-06-30 23:59 ` [patch 05/30] char: mxser, fix ISA board lookup Greg KH
2009-06-30 23:59 ` [patch 06/30] firmware_map: fix hang with x86/32bit Greg KH
2009-06-30 23:59 ` [patch 07/30] jbd: fix race in buffer processing in commit code Greg KH
2009-06-30 23:59 ` [patch 08/30] PCI: disable ASPM on VIA root-port-under-bridge configurations Greg KH
2009-06-30 23:59 ` [patch 09/30] r8169: fix crash when large packets are received Greg KH
2009-06-30 23:59 ` [patch 10/30] ISDN: Fix DMA alloc for hfcpci Greg KH
2009-06-30 23:59 ` [patch 11/30] x86: Add quirk for reboot stalls on a Dell Optiplex 360 Greg KH
2009-06-30 23:59 ` [patch 12/30] x86: quirk for reboot stalls on a Dell Optiplex 330 Greg KH
2009-06-30 23:59 ` [patch 13/30] ALSA: ca0106 - Add missing registrations of vmaster controls Greg KH
2009-06-30 23:59 ` [patch 14/30] floppy: provide a PNP device table in the module Greg KH
2009-06-30 23:59 ` [patch 15/30] floppy: request and release only the ports we actually use Greg KH
2009-07-01 0:00 ` Greg KH [this message]
2009-07-01 0:00 ` [patch 17/30] x86: handle initrd that extends into unusable memory Greg KH
2009-07-01 0:00 ` [patch 18/30] lockdep: Select frame pointers on x86 Greg KH
2009-07-01 0:00 ` [patch 19/30] md/raid5: add missing call to schedule() after prepare_to_wait() Greg KH
2009-07-01 0:00 ` [patch 20/30] tcp: advertise MSS requested by user Greg KH
2009-07-01 0:00 ` [patch 21/30] parport_pc: after superio probing restore original register values Greg KH
2009-07-01 0:00 ` [patch 22/30] parport_pc: set properly the dma_mask for parport_pc device Greg KH
2009-07-01 0:00 ` [patch 23/30] PCI PM: Fix handling of devices without PM support by pci_target_state() Greg KH
2009-07-01 0:00 ` [patch 24/30] PCI PM: Follow PCI_PM_CTRL_NO_SOFT_RESET during transitions from D3 Greg KH
2009-07-01 0:00 ` [patch 25/30] pcmcia/cm4000: fix lock imbalance Greg KH
2009-07-01 0:00 ` [patch 26/30] sound: seq_midi_event: fix decoding of (N)RPN events Greg KH
2009-07-01 0:00 ` [patch 27/30] mm: fix handling of pagesets for downed cpus Greg KH
2009-07-01 0:00 ` [patch 28/30] dm mpath: validate hw_handler argument count Greg KH
2009-07-01 0:00 ` [patch 29/30] dm mpath: validate table " Greg KH
2009-07-01 0:00 ` [patch 30/30] dm: sysfs skip output when device is being destroyed Greg KH
2009-07-01 6:04 ` [patch 00/30] 2.6.27-stable review Christoph Biedl
2009-07-01 18:49 ` [stable] " Greg KH
2009-07-17 19:43 ` Greg KH
2009-07-01 18:35 ` Greg KH
2009-07-01 18:36 ` [patch 31/30] bsdacct: fix access to invalid filp in acct_on() Greg KH
2009-07-01 18:38 ` [patch 32/30] kbuild: fix C libary confusion in unifdef.c due to getline() Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090701000358.828625631@mini.kroah.org \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jackm@dev.mellanox.co.il \
--cc=linux-kernel@vger.kernel.org \
--cc=rolandd@cisco.com \
--cc=stable-review@kernel.org \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox