Re: [patch 000/108] 2.6.30-stable review

Julien BLACHE
2009-07-01T15:41:35Z

[-- Attachment #1: Type: text/plain, Size: 574 bytes --]

Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:

Hi,

>> Felix wrote it was a candidate for stable (obviously!) but it's not on
>> the list you posted. Care to include it?
>
> I am routinely astonished by the "please include patch XY" postings. :-)

Actually I was under the impression that the proper request had been
made for inclusion into -stable, but it looks like it's not been done
after all.

So, here goes.

JB.

--
Julien BLACHE <http://www.jblache.org>
<jb@jblache.org> GPG KeyID 0xF5D65169

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: XFS 2.6.30 memleak fix --]
[-- Type: text/x-diff, Size: 889 bytes --]

From: Felix Blyakher <felixb@sgi.com>
Date: Thu, 11 Jun 2009 22:07:28 +0000 (-0500)
Subject: xfs: fix freeing memory in xfs_getbmap()
X-Git-Url: http://oss.sgi.com/cgi-bin/gitweb.cgi?p=xfs%2Fxfs.git;a=commitdiff_plain;h=7747a0b0af5976ba3828796b4f7a7adc3bb76dbd

xfs: fix freeing memory in xfs_getbmap()

Regression from commit 28e211700a81b0a934b6c7a4b8e7dda843634d2f.
Need to free temporary buffer allocated in xfs_getbmap().

Signed-off-by: Felix Blyakher <felixb@sgi.com>
Signed-off-by: Hedi Berriche <hedi@sgi.com>
Reported-by: Justin Piszcz <jpiszcz@lucidpixels.com>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---

diff --git a/fs/xfs/xfs_bmap.c b/fs/xfs/xfs_bmap.c
index 4b0f6ef..7928b99 100644
--- a/fs/xfs/xfs_bmap.c
+++ b/fs/xfs/xfs_bmap.c
@@ -6086,6 +6086,7 @@ xfs_getbmap(
break;
}

+ kmem_free(out);
return error;
}