Re: [Patch 1/3] elf: fix one check-after-use

James Morris
2009-07-01T15:14:20Z

On Wed, 1 Jul 2009, Amerigo Wang wrote:

>
> Check before use it.
>
> Signed-off-by: WANG Cong <amwang@redhat.com>
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: David Howells <dhowells@redhat.com>

Probably needs to go into Linus' tree and stable.

Acked-by: Roland McGrath <roland@redhat.com>
Acked-by: James Morris <jmorris@namei.org>

>
> ---
> Index: linux-2.6/fs/binfmt_elf.c
> ===================================================================
> --- linux-2.6.orig/fs/binfmt_elf.c
> +++ linux-2.6/fs/binfmt_elf.c
> @@ -1522,11 +1522,11 @@ static int fill_note_info(struct elfhdr
> info->thread = NULL;
>
> psinfo = kmalloc(sizeof(*psinfo), GFP_KERNEL);
> - fill_note(&info->psinfo, "CORE", NT_PRPSINFO, sizeof(*psinfo), psinfo);
> -
> if (psinfo == NULL)
> return 0;
>
> + fill_note(&info->psinfo, "CORE", NT_PRPSINFO, sizeof(*psinfo), psinfo);
> +
> /*
> * Figure out how many notes we're going to need for each thread.
> */
>

--
James Morris
<jmorris@namei.org>