From: Ingo Molnar <mingo@elte.hu>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
git-commits-head@vger.kernel.org
Subject: Re: [PATCH] kmemleak: Fix scheduling-while-atomic bug
Date: Wed, 1 Jul 2009 11:30:15 +0200 [thread overview]
Message-ID: <20090701093015.GA6862@elte.hu> (raw)
In-Reply-To: <1246439937.8492.18.camel@pc1117.cambridge.arm.com>
* Catalin Marinas <catalin.marinas@arm.com> wrote:
> > The minimal fix below removes scan_yield() and adds a
> > cond_resched() to the outmost (safe) place of the scanning
> > thread. This solves the regression.
>
> With CONFIG_PREEMPT disabled it won't reschedule during the bss
> scanning but I don't see this as a real issue (task stacks
> scanning probably takes longer anyway).
Yeah. I suspect one more cond_resched() could be added - i just
didnt see an obvious place for it, given that scan_block() is being
called with asymetric held-locks contexts.
Ingo
next prev parent reply other threads:[~2009-07-01 9:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200907010300.n6130rRf026194@hera.kernel.org>
2009-07-01 7:53 ` [PATCH] kmemleak: Fix scheduling-while-atomic bug Ingo Molnar
2009-07-01 8:10 ` Pekka Enberg
2009-07-01 9:18 ` Catalin Marinas
2009-07-01 9:30 ` Ingo Molnar [this message]
2009-07-01 9:46 ` Catalin Marinas
2009-07-01 11:04 ` Ingo Molnar
2009-07-02 12:48 ` Exiting with locks still held (was Re: [PATCH] kmemleak: Fix scheduling-while-atomic bug) Catalin Marinas
2009-07-02 12:54 ` Pekka Enberg
2009-07-02 13:06 ` Catalin Marinas
2009-07-02 14:13 ` Catalin Marinas
2009-07-02 17:39 ` Linus Torvalds
2009-07-03 10:18 ` Catalin Marinas
2009-07-03 7:04 ` Ingo Molnar
2009-07-02 9:48 ` [PATCH] kmemleak: Fix scheduling-while-atomic bug Catalin Marinas
2009-07-03 7:00 ` [PATCH] kmemleak: Mark nice +10 Ingo Molnar
2009-07-03 8:09 ` Catalin Marinas
2009-07-08 13:33 ` [PATCH] kmemleak: Fix scheduling-while-atomic bug Catalin Marinas
2009-08-23 2:48 ` Ming Lei
2009-08-23 14:59 ` Catalin Marinas
2009-08-24 0:10 ` Ming Lei
2009-08-24 10:02 ` ACPI scheduling while atomic (was: Re: [PATCH] kmemleak: Fix scheduling-while-atomic bug) Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090701093015.GA6862@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=git-commits-head@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox