Re: [PATCH 3/3 -tip] perf list: avoid replicating functions

Ingo Molnar
2009-07-04T09:51:02Z

* Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:

> On Fri, 2009-07-03 at 11:30 +0200, Ingo Molnar wrote:
> > * Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:
> >
> > > > $ ./perf list shows vector events like :
> > > >
> > > > vec-adds OR add [Hardware vector event]
> > > > vec-muls OR multiply [Hardware vector event]
> > > > vec-divs OR divide [Hardware vector event]
> > > > vec-idle-cycles OR vec-empty-cycles [Hardware vector event]
> > > > vec-stall-cycles OR vec-busy-cycles [Hardware vector event]
> > > > vec-ops OR vec-operations [Hardware vector event]
> >
> > btw., why does this printout SHOUT the 'or'? It's certainly not an
> > important piece of information. Something like:
> >
> > vec-adds | add [Hardware vector event]
> > vec-muls | multiply [Hardware vector event]
> > vec-divs | divide [Hardware vector event]
> > vec-idle-cycles | vec-empty-cycles [Hardware vector event]
> > vec-stall-cycles | vec-busy-cycles [Hardware vector event]
> > vec-ops | vec-operations [Hardware vector event]
> >
> > looks better on all levels.
> >
>
> I prepared this patch incrementally on :
> [PATCH 1/2 -tip] perf_counter: Add generalized hardware vectored co-processor support for AMD and Intel Corei7/Nehalem
> [PATCH 2/2 -tip] perf_counter: Add generalized hardware interrupt support for AMD and Intel Corei7/Nehalem, Core2 and Atom
>
> [PATCH 3/3] perf list: avoid replicating functions
>
> vector and interrupt can use same function made for hardware and
> software generic events.
>
> Also replaced 'OR' with '|'

Please submit a clean series of patches instead of a mixture of
patches plus fixes to patches.

Ingo