Re: [PATCH 3/6 -tip] perf_counter: Add Generalized Hardware vectored co-processor support for AMD

Ingo Molnar
2009-07-01T11:51:19Z

* Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:

> On Wed, 2009-07-01 at 13:27 +0200, Ingo Molnar wrote:
> > * Ingo Molnar <mingo@elte.hu> wrote:
> >
> > > > Performance counter stats for '/usr/bin/vlc /home/jaswinder/Videos/Linus_Torvalds_interview_with_Charlie_Rose_Part_1.flv':
> > > >
> > > > 20177177044 vec-adds (scaled from 66.63%)
> > > > 34101687027 vec-muls (scaled from 66.64%)
> > > > 3984060862 vec-divs (scaled from 66.71%)
> > > > 26349684710 vec-idle-cycles (scaled from 66.65%)
> > > > 9052001905 vec-stall-cycles (scaled from 66.66%)
> > > > 76440734242 vec-ops (scaled from 66.71%)
> > > >
> > > > 272.523058097 seconds time elapsed
> >
> > btw., the 'perf list' bits are missing - any new counter added
> > should be listed by 'perf list' as well - otherwise people wont know
> > what we have and what to use.
> >
>
> Even cache is not available for 'perf list'. Should I also resend
> patch for adding cache along with vector and interrupt.

I'd suggest for you to send a separate patch for the cache bits
first (that way it's not held up by other dependencies) - and keep
the vector and irq bits in their respective patches.

I.e. when we add new generic events, we want to enable it in the
full tool-space in a single patch.

Ingo