Re: [PATCH 2/2 -tip] perf_counter: Add generalized hardware interrupt support for AMD and Intel Corei7/Nehalem, Core2 and Atom

Ingo Molnar
2009-07-03T10:33:39Z

* Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:

> $ ./perf stat -e interrupts -e masked -e int-pending-mask-cycles -- ls -lR /usr/include/ > /dev/null
>
> Performance counter stats for 'ls -lR /usr/include/':
>
> 377 interrupts
> 53429936 int-mask-cycles
> 1119 int-pending-mask-cycles

What's your take on my review feedback:

> We could and should probably add a software counter for hardirqs
> as well. That would allow the vector/irqnr information to be
> passed in, and it would allow architectures without irq metrics in
> the PMU to have this counter too.
>
> This way we could profile based on a specific interrupt source
> only - say based on the networking card.

Why did you resend the patch while there was still unanswered review
feedback?

Ingo