The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Oliver Neukum <oliver@neukum.org>
To: Arseniy Lartsev <ars3n@yandex.ru>
Cc: Alan Stern <stern@rowland.harvard.edu>,
	USB list <linux-usb@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: PROBLEM: USB ACM device does not work
Date: Wed, 1 Jul 2009 12:56:46 +0200	[thread overview]
Message-ID: <200907011256.47550.oliver@neukum.org> (raw)
In-Reply-To: <200907011301.06574.ars3n@yandex.ru>

Am Mittwoch, 1. Juli 2009 11:01:06 schrieb Arseniy Lartsev:
> On Wednesday 01 July 2009 01:01:00 Alan Stern wrote:
> > This looks like your problem.  Low-speed devices are not allowed to
> > have bulk endpoints.  Linux internally changes them to interrupt
> > endpoints with interval = 1 and maxpacket size no larger than 8.
>
> Maybe this device is a little "buggy". But Linux should support buggy
> devices as well.

Yes, it should. We just needed to understand why it failed.


> +		ep = (usb_pipein(acm->rx_endpoint) ? acm->dev->ep_in : acm->dev->ep_out)
> +				[usb_pipeendpoint(acm->rx_endpoint)];
> +		if (usb_endpoint_xfer_int(&ep->desc))
> +			usb_fill_int_urb(rcv->urb, acm->dev,
> +					 acm->rx_endpoint,
> +					 buf->base,
> +					 acm->readsize,
> +					 acm_read_bulk, rcv, 0xff);

The patch is good except for this.
We should make sure this interval matches usbcore's value.
Would you care to redo it with that change?

	Regards
		Oliver


  reply	other threads:[~2009-07-01 10:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-28 18:29 PROBLEM: USB ACM device does not work Arseniy Lartsev
2009-06-28 20:20 ` Oliver Neukum
2009-06-28 20:37   ` Arseniy Lartsev
2009-06-28 20:58 ` Oliver Neukum
2009-06-29 11:43   ` Arseniy Lartsev
2009-06-29 13:07     ` Oliver Neukum
2009-06-29 13:35       ` Arseniy Lartsev
2009-06-30  7:22         ` Oliver Neukum
2009-06-30 20:09           ` Arseniy Lartsev
2009-06-30 21:01             ` Alan Stern
2009-07-01  9:01               ` Arseniy Lartsev
2009-07-01 10:56                 ` Oliver Neukum [this message]
2009-07-01 11:24                   ` Arseniy Lartsev
2009-07-01 11:37                     ` Oliver Neukum
2009-07-01 12:27                       ` [PATCH] cdc-acm: work around some broken devices Arseniy Lartsev
2009-07-01 13:56                         ` Greg KH
2009-07-01 14:03                           ` Oliver Neukum
2009-07-01 14:34                         ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907011256.47550.oliver@neukum.org \
    --to=oliver@neukum.org \
    --cc=ars3n@yandex.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox