[patch 102/108] lib/genalloc.c: remove unmatched write_lock() in gen_pool_destroy

Greg KH
2009-07-01T01:17:05Z

[-- Attachment #1: lib-genalloc.c-remove-unmatched-write_lock-in-gen_pool_destroy.patch --]
[-- Type: text/plain, Size: 1248 bytes --]

2.6.30-stable review patch. If anyone has any objections, please let us know.

------------------

From: Zygo Blaxell <zygo.blaxell@xandros.com>

commit 8e8a2dea0ca91fe2cb7de7ea212124cfe8c82c35 upstream.

There is a call to write_lock() in gen_pool_destroy which is not balanced
by any corresponding write_unlock(). This causes problems with preemption
because the preemption-disable counter is incremented in the write_lock()
call, but never decremented by any call to write_unlock(). This bug is
gen_pool_destroy, and one of them is non-x86 arch-specific code.

Signed-off-by: Zygo Blaxell <zygo.blaxell@xandros.com>
Cc: Jiri Kosina <trivial@kernel.org>
Cc: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
lib/genalloc.c | 1 -
1 file changed, 1 deletion(-)

--- a/lib/genalloc.c
+++ b/lib/genalloc.c
@@ -85,7 +85,6 @@ void gen_pool_destroy(struct gen_pool *p
int bit, end_bit;

- write_lock(&pool->lock);
list_for_each_safe(_chunk, _next_chunk, &pool->chunks) {
chunk = list_entry(_chunk, struct gen_pool_chunk, next_chunk);
list_del(&chunk->next_chunk);