From: Jean Delvare <khali@linux-fr.org>
To: "Chris Verges" <chrisv@cyberswitching.com>
Cc: "Jonathan Cameron" <jic23@cam.ac.uk>,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [PATCH] adxl345 accelerometer hwmon driver
Date: Wed, 1 Jul 2009 22:13:10 +0200 [thread overview]
Message-ID: <20090701221310.1d6aa587@hyperion.delvare> (raw)
In-Reply-To: <68FBE0F3CE97264395875AC1C468F22C152BFA@mail03.cyberswitching.local>
On Wed, 1 Jul 2009 12:19:02 -0700, Chris Verges wrote:
> > What are you actually doing with it? If you aren't doing hardware
> > monitoring then I would expect you aren't going to receive a
> > favourable response on here.
>
> The ADXL345 is a 3D accelerometer. It's very similar to the following
> chips already in the HWMON section of the kernel:
>
> - SENSORS_LIS3LV02D
> - SENSORS_APPLESMC
>
> The driver provides 3D axis data when the user polls the chip via the
> sysfsinterface.
A few accelerometer drivers were originally added to drivers/hwmon
because the chips also included some hwmon features (e.g. temperature
sensor.) Now every new accelerometer driver gets dropped in
drivers/hwmon "because there are other accelerometer drivers there".
The LIS3LV02D driver is a perfect example of this... the device is not
even registered as a hwmon driver! This driver definitely doesn't
belong there.
Probably it's about time to put an end to this and kick all
accelerometer drivers out of drivers/hwmon.
--
Jean Delvare
next prev parent reply other threads:[~2009-07-01 20:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Acn6eDhBoTUmzVqOSVGG9a2LiwqVrA==>
2009-07-01 18:17 ` [PATCH] adxl345 accelerometer hwmon driver Chris Verges
2009-07-01 19:10 ` [lm-sensors] " Jonathan Cameron
2009-07-01 19:19 ` Chris Verges
2009-07-01 20:13 ` Jean Delvare [this message]
2009-07-01 20:52 ` Chris Verges
2009-07-02 11:25 ` Jean Delvare
2009-07-02 13:55 ` Jonathan Cameron
2009-07-02 8:04 ` Éric Piel
2009-07-01 19:33 ` [lm-sensors] " Jean Delvare
2009-07-02 17:38 ` Jonathan Cameron
2009-07-02 17:43 ` Mike Frysinger
2009-07-02 17:59 ` Jonathan Cameron
2009-07-02 18:12 ` Hennerich, Michael
2009-07-02 18:15 ` Mike Frysinger
2009-07-02 17:59 ` Hennerich, Michael
2009-08-14 11:05 ` XingChao Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090701221310.1d6aa587@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=chrisv@cyberswitching.com \
--cc=jic23@cam.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox