From: Borislav Petkov <borislav.petkov@amd.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>,
Greg KH <gregkh@suse.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Kurt Garloff <garloff@suse.de>,
linux-kernel@vger.kernel.org, Yinghai Lu <yinghai@kernel.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Doug Thompson <norsk5@yahoo.com>, Dave Jiang <djiang@mvista.com>
Subject: Re: [PATCH] x86: sysctl to allow panic on IOCK NMI error
Date: Thu, 2 Jul 2009 12:41:11 +0200 [thread overview]
Message-ID: <20090702104111.GA24940@aftab> (raw)
In-Reply-To: <20090702075305.GC19187@elte.hu>
On Thu, Jul 02, 2009 at 09:53:05AM +0200, Ingo Molnar wrote:
> > That shouldn't be a problem if we were about to panic(). For a
> > more sophisticated attempt of recovery -- yes, that would have to
> > be addressed.
>
> We are only panic-ing if the sysctl is set. The diagnostics would be
> useful anyway. The proper approach would be to defer it a bit in the
> non-panic case an read it out from some friendlier context - such as
> the EDAC core.
Quickly skimming through code shows some functionality is there:
drivers/edac/edac_pci{,_sysfs}.c but doesn't seem to be NMI safe. CCing
some more people.
--
Regards/Gruss,
Boris.
Operating | Advanced Micro Devices GmbH
System | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany
Research | Geschäftsführer: Thomas M. McCoy, Giuliano Meroni
Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
(OSRC) | Registergericht München, HRB Nr. 43632
next prev parent reply other threads:[~2009-07-02 10:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-24 21:32 [PATCH] x86: sysctl to allow panic on IOCK NMI error Greg KH
2009-06-25 9:16 ` [tip:x86/urgent] x86: Add " tip-bot for Kurt Garloff
2009-06-25 18:15 ` [PATCH] x86: " Eric W. Biederman
2009-06-25 20:07 ` Greg KH
2009-06-25 20:18 ` Ingo Molnar
2009-06-25 20:16 ` Greg KH
2009-06-25 20:06 ` [tip:x86/urgent] x86: Add " tip-bot for Kurt Garloff
2009-06-25 20:09 ` tip-bot for Kurt Garloff
2009-06-30 22:27 ` [PATCH] x86: " Maciej W. Rozycki
2009-06-30 22:30 ` Greg KH
2009-07-01 0:50 ` Maciej W. Rozycki
2009-07-01 11:10 ` Ingo Molnar
2009-07-01 17:30 ` Jesse Barnes
2009-07-01 17:37 ` Maciej W. Rozycki
2009-07-02 7:53 ` Ingo Molnar
2009-07-02 10:41 ` Borislav Petkov [this message]
2009-07-03 7:59 ` Ingo Molnar
2009-07-03 21:35 ` Maciej W. Rozycki
2009-07-03 9:19 ` Kurt Garloff
2009-07-03 9:24 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090702104111.GA24940@aftab \
--to=borislav.petkov@amd.com \
--cc=djiang@mvista.com \
--cc=garloff@suse.de \
--cc=gregkh@suse.de \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=mingo@elte.hu \
--cc=norsk5@yahoo.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox