good example of a tty driver

good example of a tty driver

[Kumar Gala]

Alan,

Can you point me at any good drivers to use as an example of using the  
tty layer.  I'm trying to get an out of tree driver brought up to date  
for the Avocent ESP-16 MI Serial Hubs (serial over ethernet):

http://www.connectivity.avocent.com/products/network-based/esp_16.asp

Thankfully the have a GPL driver but it was last updated against 2.6.23:

http://www.connectivity.avocent.com/drivers/esp_serial_hubs/dd64e069.asp

However I've never worked on any tty drivers so its a bit black magic  
at this point.  I was hoping that an example would at least get me  
able to bring the driver up to a point that we can get it into the  
staging tree.

thanks

- k

Re: good example of a tty driver

[Alan Cox]

On Thu, 2 Jul 2009 11:48:09 -0500
Kumar Gala <galak@kernel.crashing.org> wrote:

> Alan,
> 
> Can you point me at any good drivers to use as an example of using the  
> tty layer.  I'm trying to get an out of tree driver brought up to date  
> for the Avocent ESP-16 MI Serial Hubs (serial over ethernet):

Its very much in flux with the drivers getting kref support, helper
functions and the like in the current releases.

> 
> http://www.connectivity.avocent.com/products/network-based/esp_16.asp
> 
> Thankfully the have a GPL driver but it was last updated against 2.6.23:
> 
> http://www.connectivity.avocent.com/drivers/esp_serial_hubs/dd64e069.asp
> 
> However I've never worked on any tty drivers so its a bit black magic  
> at this point.  I was hoping that an example would at least get me  
> able to bring the driver up to a point that we can get it into the  
> staging tree.

I would make it build, chuck it in the staging tree and go from there

isicom has a fairly good use of the newer helper functions we have so far
and struct tty_port so is probably as good an example as any if the
driver is using drivers/char. If its using the serial layer helpers then
apart from making sure you report the actual baud rate and termios
settings back little has changed (its all been hidden in the midlayer)

Re: good example of a tty driver

[Greg KH]

On Thu, Jul 02, 2009 at 07:27:44PM +0100, Alan Cox wrote:
> On Thu, 2 Jul 2009 11:48:09 -0500
> Kumar Gala <galak@kernel.crashing.org> wrote:
> 
> > Alan,
> > 
> > Can you point me at any good drivers to use as an example of using the  
> > tty layer.  I'm trying to get an out of tree driver brought up to date  
> > for the Avocent ESP-16 MI Serial Hubs (serial over ethernet):
> 
> Its very much in flux with the drivers getting kref support, helper
> functions and the like in the current releases.
> 
> > 
> > http://www.connectivity.avocent.com/products/network-based/esp_16.asp
> > 
> > Thankfully the have a GPL driver but it was last updated against 2.6.23:
> > 
> > http://www.connectivity.avocent.com/drivers/esp_serial_hubs/dd64e069.asp
> > 
> > However I've never worked on any tty drivers so its a bit black magic  
> > at this point.  I was hoping that an example would at least get me  
> > able to bring the driver up to a point that we can get it into the  
> > staging tree.
> 
> I would make it build, chuck it in the staging tree and go from there

That sounds good to me as well.  Kumar, feel free to send me a patch :)

thanks,

greg k-h

Re: good example of a tty driver

[Joe Perches]

On Thu, 2009-07-02 at 11:31 -0700, Greg KH wrote:
> On Thu, Jul 02, 2009 at 07:27:44PM +0100, Alan Cox wrote:
> > On Thu, 2 Jul 2009 11:48:09 -0500
> > Kumar Gala <galak@kernel.crashing.org> wrote:
> > > Thankfully the have a GPL driver but it was last updated against 2.6.23:
> > > http://www.connectivity.avocent.com/drivers/esp_serial_hubs/dd64e069.asp
> > > However I've never worked on any tty drivers so its a bit black magic  
> > > at this point.  I was hoping that an example would at least get me  
> > > able to bring the driver up to a point that we can get it into the  
> > > staging tree.
> > I would make it build, chuck it in the staging tree and go from there
> That sounds good to me as well.  Kumar, feel free to send me a patch :)

I was playing around the the digi dgap driver which is out of tree.

Scott, do you or Digi have any objections in putting the dgap driver
into staging as well?