From: Jens Axboe <jens.axboe@oracle.com>
To: "Miller, Mike (OS Dev)" <Mike.Miller@hp.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: Re: [PATCH] cciss: Ignore stale commands after reboot
Date: Thu, 2 Jul 2009 22:01:04 +0200 [thread overview]
Message-ID: <20090702200104.GF23611@kernel.dk> (raw)
In-Reply-To: <0F5B06BAB751E047AB5C87D1F77A77886948B9516C@GVW0547EXC.americas.hpqcorp.net>
On Thu, Jul 02 2009, Miller, Mike (OS Dev) wrote:
>
>
> > -----Original Message-----
> > From: Andrew Morton [mailto:akpm@linux-foundation.org]
> > Sent: Thursday, July 02, 2009 2:51 PM
> > To: Miller, Mike (OS Dev)
> > Subject: Fw: Re: [PATCH] cciss: Ignore stale commands after reboot
> >
> >
> > oh, Jens already did it.
> >
> > Begin forwarded message:
> >
> > Date: Thu, 2 Jul 2009 21:00:49 +0200
> > From: Jens Axboe <jens.axboe@oracle.com>
> > To: Hannes Reinecke <hare@suse.de>
> > Cc: scameron@beardog.cca.cpqcorp.net,
> > linux-kernel@vger.kernel.org, mikem@beardog.cca.cpqcorp.net
> > Subject: Re: [PATCH] cciss: Ignore stale commands after reboot
> >
> >
> > On Thu, Jul 02 2009, Hannes Reinecke wrote:
> > >
> > > When doing an unexpected shutdown like kexec the cciss
> > firmware might
> > > still have some commands in flight, which it is trying to complete.
> > > The driver is doing it's best on resetting the HBA, but
> > sadly there's
> > > a firmware issue causing the firmware _not_ to abort or drop old
> > > commands.
> > > So the firmware will send us commands which we haven't
> > accounted for,
> > > causing the driver to panic.
> > >
> > > With this patch we're just ignoring these commands as there
> > is nothing
> > > we could be doing with them anyway.
> >
> > Looks good to me. Mike, Stephen?
>
> Sorry I haven't seen this before. The beardog addresses are no longer
> valid. We moved into a dungeon and into a new domain. The good folks
> in IT have yet to assign another IP address/domain name or an MX
> record for the mail servers. I hope that by next week that will be
> corrected. Until then all Steve and I have to use is some form of
> OutHouse mail client.
>
> Acked-by: Mike Miller <mike.miller@hp.com>
OK, I'll add the patch with your ack.
--
Jens Axboe
next prev parent reply other threads:[~2009-07-02 20:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090702125030.d9967a7f.akpm@linux-foundation.org>
2009-07-02 19:58 ` Re: [PATCH] cciss: Ignore stale commands after reboot Miller, Mike (OS Dev)
2009-07-02 20:01 ` Jens Axboe [this message]
2009-07-02 20:06 ` Miller, Mike (OS Dev)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090702200104.GF23611@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=Mike.Miller@hp.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox