public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alek Du <alek.du@intel.com>
To: Andrey Panin <pazke@centrinvest.ru>
Cc: David Brownell <david-b@pacbell.net>,
	Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] gpio: add Intel Moorestown Platform Langwell chip gpio driver
Date: Thu, 2 Jul 2009 23:38:34 +0800	[thread overview]
Message-ID: <20090702233834.00004c32@unknown> (raw)
In-Reply-To: <20090702140022.GA18313@centrinvest.ru>

Hi Andrey,

On Thu, 2 Jul 2009 22:00:22 +0800
Andrey Panin <pazke@centrinvest.ru> wrote:

> On 183, 07 02, 2009 at 08:43:35PM +0800, Alek Du wrote:
> > Changes from v1:
> > 1. driver name changed from lnw.c ==> langwell_gpio.c
> > 2. removed hard coded driver data, now we get it from PCI bar1
> > (platform init code fills it) 3. removed alternative function
> > setting code, it should be called in platform init part. 4. misc.
> > style clean
> > 
> > From abdf5c678c1df2dc5538628bba5578b92ce5ac4e Mon Sep 17 00:00:00
> > 2001 From: Alek Du <alek.du@intel.com>
> > Date: Tue, 30 Jun 2009 12:13:27 +0800
> > Subject: [PATCH] gpio: add Intel Moorestown Platform Langwell chip
> > gpio driver
> > 
> > The Langwell chip is the IO hub for Intel Moorestown platform which
> > has a 64-pin gpio block device inside. It is exposed as a PCI
> > device. We use it to control outside peripheral as well as to do
> > IRQ demuxing. The gpio block uses MSI to request level type
> > interrupt to IOAPIC.
> 
> There is no MODULE_DEVICE_TABLE() in the driver, is this intentional ?
> 
Thanks for the catch, I should add it.

Thanks,
Alek 


      reply	other threads:[~2009-07-02 15:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-02 12:43 [PATCH v2] gpio: add Intel Moorestown Platform Langwell chip gpio driver Alek Du
2009-07-02 14:00 ` Andrey Panin
2009-07-02 15:38   ` Alek Du [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090702233834.00004c32@unknown \
    --to=alek.du@intel.com \
    --cc=david-b@pacbell.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pazke@centrinvest.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox