Re: [PATCH v2] gpio: add Intel Moorestown Platform Langwell chip gpio driver

Alek Du
2009-07-02T15:39:46Z

Hi Andrey,

On Thu, 2 Jul 2009 22:00:22 +0800
Andrey Panin <pazke@centrinvest.ru> wrote:

> On 183, 07 02, 2009 at 08:43:35PM +0800, Alek Du wrote:
> > Changes from v1:
> > 1. driver name changed from lnw.c ==> langwell_gpio.c
> > 2. removed hard coded driver data, now we get it from PCI bar1
> > (platform init code fills it) 3. removed alternative function
> > setting code, it should be called in platform init part. 4. misc.
> > style clean
> >
> > From abdf5c678c1df2dc5538628bba5578b92ce5ac4e Mon Sep 17 00:00:00
> > 2001 From: Alek Du <alek.du@intel.com>
> > Date: Tue, 30 Jun 2009 12:13:27 +0800
> > Subject: [PATCH] gpio: add Intel Moorestown Platform Langwell chip
> > gpio driver
> >
> > The Langwell chip is the IO hub for Intel Moorestown platform which
> > has a 64-pin gpio block device inside. It is exposed as a PCI
> > device. We use it to control outside peripheral as well as to do
> > IRQ demuxing. The gpio block uses MSI to request level type
> > interrupt to IOAPIC.
>
> There is no MODULE_DEVICE_TABLE() in the driver, is this intentional ?
>
Thanks for the catch, I should add it.

Thanks,
Alek