From: Ingo Molnar <mingo@elte.hu>
To: venkatesh.pallipadi@intel.com
Cc: Dave Jones <davej@redhat.com>,
linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org,
kernel-testers@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
Dave Young <hidave.darkstar@gmail.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Thomas Renninger <trenn@suse.de>
Subject: Re: [patch 0/4] Take care of cpufreq lockdep issues (take 2)
Date: Fri, 3 Jul 2009 08:54:27 +0200 [thread overview]
Message-ID: <20090703065427.GA32687@elte.hu> (raw)
In-Reply-To: <20090703000829.735976000@intel.com>
* venkatesh.pallipadi@intel.com <venkatesh.pallipadi@intel.com> wrote:
> Since recent chanegs to ondemand and conservative governor, there
> have been multiple reports of lockdep issues in cpufreq. Patch
> series takes care of these problems.
>
> This is the next attempt following the one here, which was not a
> complete fix.
> http://lkml.indiana.edu/hypermail/linux/kernel/0906.3/01073.html
>
> I am currently running some stress tests to make sure there are no
> issues with these patches. But, wanted to send them out for
> review/comments/testing before I head out for the long weekend.
>
> If this patchset seems sane, the first patch in the patchset
> should also get into 30.stable.
Btw., FYI, because my test-systems were frequently triggering those
bugs, i kept testing the following series from you and Mathieu in
-tip:
ecf8b04: cpufreq: Define dbs_mutex purpose and cleanup its usage conservative gov
b08c597: cpufreq: Define dbs_mutex purpose and cleanup its usage
0807e30: cpufreq: remove rwsem lock from CPUFREQ_GOV_STOP call (second call site)
So that fix-series, while probably not complete (given that you sent
a v2 series), worked well in practice and gets my:
Tested-by: Ingo Molnar <mingo@elte.hu>
Is the delta between this (tested) series and your v2 version
significant? If not it might make sense to shape it as a delta patch
to the v1 series, if that looks clean enough - to preserve testing
results.
Ingo
next prev parent reply other threads:[~2009-07-03 6:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-03 0:08 [patch 0/4] Take care of cpufreq lockdep issues (take 2) venkatesh.pallipadi
2009-07-03 0:08 ` [patch 1/4] cpufreq: Eliminate the recent lockdep warnings in cpufreq venkatesh.pallipadi
2009-07-03 1:06 ` Mathieu Desnoyers
2009-07-03 2:04 ` Pallipadi, Venkatesh
2009-07-03 2:25 ` Mathieu Desnoyers
2009-07-03 11:41 ` Thomas Renninger
2009-07-03 14:28 ` Pallipadi, Venkatesh
2009-07-06 11:19 ` Thomas Renninger
2009-07-03 0:08 ` [patch 2/4] cpufreq: Mark policy_rwsem as going static in cpufreq.c wont be exported venkatesh.pallipadi
2009-07-03 0:08 ` [patch 3/4] cpufreq: Cleanup locking in ondemand governor venkatesh.pallipadi
2009-07-03 0:08 ` [patch 4/4] cpufreq: Cleanup locking in conservative governor venkatesh.pallipadi
2009-07-03 2:23 ` [PATCH] CPUFREQ: fix (utter) cpufreq_add_dev mess v1 Mathieu Desnoyers
2009-07-03 6:54 ` Ingo Molnar [this message]
2009-07-03 14:06 ` [patch 0/4] Take care of cpufreq lockdep issues (take 2) Mathieu Desnoyers
2009-07-03 14:31 ` Pallipadi, Venkatesh
2009-07-03 18:48 ` Ingo Molnar
2009-07-06 18:52 ` Pallipadi, Venkatesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090703065427.GA32687@elte.hu \
--to=mingo@elte.hu \
--cc=cpufreq@vger.kernel.org \
--cc=davej@redhat.com \
--cc=hidave.darkstar@gmail.com \
--cc=kernel-testers@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=penberg@cs.helsinki.fi \
--cc=rjw@sisk.pl \
--cc=trenn@suse.de \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox