public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Pavel Machek <pavel@ucw.cz>
Cc: Joseph Cihula <joseph.cihula@intel.com>,
	linux-kernel@vger.kernel.org, arjan@linux.intel.com,
	hpa@zytor.com, andi@firstfloor.org, chrisw@sous-sol.org,
	jmorris@namei.org, jbeulich@novell.com, peterm@redhat.com,
	gang.wei@intel.com, shane.wang@intel.com
Subject: Re: [RFC v6][PATCH 4/4] intel_txt: force IOMMU on for Intel(R) TXT launch
Date: Fri, 3 Jul 2009 10:21:11 +0200	[thread overview]
Message-ID: <20090703082111.GD21833@elte.hu> (raw)
In-Reply-To: <20090702213013.GC1419@ucw.cz>


* Pavel Machek <pavel@ucw.cz> wrote:

> 
> On Tue 2009-06-30 19:31:10, Joseph Cihula wrote:
> > The tboot module will DMA protect all of memory in order to ensure the that
> > kernel will be able to initialize without compromise (from DMA).  Consequently,
> > the kernel must enable Intel(R) Virtualization Technology for Directed I/O
> > (VT-d or Intel IOMMU) in order to replace this broad protection with the
> > appropriate page-granular protection.  Otherwise DMA devices will be unable
> > to read or write from memory and the kernel will eventually panic.
> > 
> > Because runtime IOMMU support is configurable by command line options, this
> > patch will force it to be enabled regardless of the options specified, and will
> > log a message if it was required to force it on.
> > 
> > 
> >  dmar.c        |    7 +++++++
> >  intel-iommu.c |   17 +++++++++++++++--
> >  2 files changed, 22 insertions(+), 2 deletions(-)
> > 
> > Signed-off-by: Joseph Cihula <joseph.cihula@intel.com>
> > Signed-off-by: Shane Wang <shane.wang@intel.com>
> 
> NAK. Breaks user expectations, misses  docs updates. 

What's your proposed solution? If an incompatible IOMMU option is 
specified should the kernel to disable TXT and panic?

	Ingo

  reply	other threads:[~2009-07-03  8:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-01  2:31 [RFC v6][PATCH 4/4] intel_txt: force IOMMU on for Intel(R) TXT launch Joseph Cihula
2009-07-02 21:30 ` Pavel Machek
2009-07-03  8:21   ` Ingo Molnar [this message]
2009-07-05 20:23     ` Pavel Machek
2009-07-05 20:26       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090703082111.GD21833@elte.hu \
    --to=mingo@elte.hu \
    --cc=andi@firstfloor.org \
    --cc=arjan@linux.intel.com \
    --cc=chrisw@sous-sol.org \
    --cc=gang.wei@intel.com \
    --cc=hpa@zytor.com \
    --cc=jbeulich@novell.com \
    --cc=jmorris@namei.org \
    --cc=joseph.cihula@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=peterm@redhat.com \
    --cc=shane.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox