From: Ingo Molnar <mingo@elte.hu>
To: Paul Mackerras <paulus@samba.org>
Cc: Jaswinder Singh Rajput <jaswinder@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/6 -tip] perf stat: treat same behaviour for all CYCLES and CLOCKS
Date: Fri, 3 Jul 2009 10:27:34 +0200 [thread overview]
Message-ID: <20090703082734.GE21833@elte.hu> (raw)
In-Reply-To: <19021.48828.428272.100850@cargo.ozlabs.ibm.com>
* Paul Mackerras <paulus@samba.org> wrote:
> Ingo Molnar writes:
>
> > Other 'compound' events might be possible too: for example a new
> > cache-hits field could be is cache-refs minus cache-misses.
>
> Hmmm, on the MPC7450 family there are events for cache-hits and
> cache-misses, so there it would be nice to be able to ask for
> cache-refs and have it compute cache-hits plus cache-misses.
Yes. I think the API is structured enough so that user-space knows
enough about the meaning of the events here. We can certainly
stipulate this rule:
refs == hits + misses
And if the kernel returns -ENODEV for a particular component
user-space can fall back using the other two events.
I.e. this would allow transparent support for all 3 permutations:
hw has refs and hits
hw has refs and misses
hw has hits and misses
For sampling it's a tiny bit tricky but still doable:j a compound
counter could still sample because we handle weighted samples
throughout the tools and negative weight can be subtraced.
Intuitive annotation output would have to be thought out for this as
entries/function could go negative statistically.
> > I.e. the simplest model for 'compound' events would be:
> >
> > X = A / B
> > X = A - B
> > X = A + B
> >
> > We could list them in the event table, with a flag that
> > specifies which arithmetic operation connects two 'atomic'
> > counters.
> >
> > Then the adding of a new compound event would only be the matter
> > of adding one more line to the event table.
>
> Sounds nice. If we do this we should ensure that the two events
> get put into one group if possible.
Correct. Are you interested in adding this, so that it fits the
MPC7450 family perfectly?
Ingo
next prev parent reply other threads:[~2009-07-03 8:28 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 9:33 [GIT-PULL -tip][PATCH 0/6] perf_counter patches Jaswinder Singh Rajput
2009-07-01 9:35 ` [PATCH 1/6 -tip] perf stat: define MATCH_EVENT for easy attrs checking Jaswinder Singh Rajput
2009-07-01 9:36 ` [PATCH 2/6 -tip] perf stat: treat same behaviour for all CYCLES and CLOCKS Jaswinder Singh Rajput
2009-07-01 9:37 ` [PATCH 3/6 -tip] perf_counter: Add Generalized Hardware vectored co-processor support for AMD Jaswinder Singh Rajput
2009-07-01 9:38 ` [PATCH 4/6 -tip] perf_counter: Add Generalized Hardware interrupt " Jaswinder Singh Rajput
2009-07-01 9:38 ` [PATCH 5/6 -tip] perf_counter: Add hardware vector events for nehalem Jaswinder Singh Rajput
2009-07-01 9:40 ` [PATCH 6/6 -tip] perf_counter: Add hardware interrupt events for nehalem, core2 and atom Jaswinder Singh Rajput
2009-07-01 11:24 ` [PATCH 4/6 -tip] perf_counter: Add Generalized Hardware interrupt support for AMD Ingo Molnar
2009-07-03 12:01 ` Jaswinder Singh Rajput
2009-07-04 10:22 ` Ingo Molnar
2009-07-04 14:17 ` Jaswinder Singh Rajput
2009-07-05 1:11 ` Ingo Molnar
2009-07-05 4:29 ` Jaswinder Singh Rajput
2009-07-05 8:04 ` Ingo Molnar
2009-07-05 9:01 ` Jaswinder Singh Rajput
2009-07-05 9:55 ` Jaswinder Singh Rajput
2009-07-01 11:20 ` [PATCH 3/6 -tip] perf_counter: Add Generalized Hardware vectored co-processor " Ingo Molnar
2009-07-01 11:27 ` Ingo Molnar
2009-07-01 11:40 ` Jaswinder Singh Rajput
2009-07-01 11:49 ` Ingo Molnar
2009-07-02 9:44 ` [PATCH 1/2 -tip] perf_counter: Add generalized hardware vectored co-processor support for AMD and Intel Corei7/Nehalem Jaswinder Singh Rajput
2009-07-02 9:45 ` [PATCH 2/2 -tip] perf_counter: Add generalized hardware interrupt support for AMD and Intel Corei7/Nehalem, Core2 and Atom Jaswinder Singh Rajput
2009-07-03 10:33 ` Ingo Molnar
2009-07-03 7:38 ` [PATCH 1/2 -tip] perf_counter: Add generalized hardware vectored co-processor support for AMD and Intel Corei7/Nehalem Jaswinder Singh Rajput
2009-07-03 9:30 ` Ingo Molnar
2009-07-03 10:10 ` Jaswinder Singh Rajput
2009-07-03 12:17 ` [PATCH 3/3 -tip] perf list: avoid replicating functions Jaswinder Singh Rajput
2009-07-04 9:50 ` Ingo Molnar
2009-07-03 10:29 ` [PATCH 1/2 -tip] perf_counter: Add generalized hardware vectored co-processor support for AMD and Intel Corei7/Nehalem Ingo Molnar
2009-07-03 11:55 ` Jaswinder Singh Rajput
2009-07-03 12:49 ` Jaswinder Singh Rajput
2009-07-03 13:25 ` Jaswinder Singh Rajput
2009-07-04 10:03 ` Ingo Molnar
2009-07-04 14:05 ` Jaswinder Singh Rajput
2009-07-04 9:49 ` Ingo Molnar
2009-07-04 13:54 ` Jaswinder Singh Rajput
2009-07-01 11:39 ` [PATCH 2/6 -tip] perf stat: treat same behaviour for all CYCLES and CLOCKS Ingo Molnar
2009-07-03 8:18 ` Paul Mackerras
2009-07-03 8:27 ` Ingo Molnar [this message]
2009-07-01 11:30 ` [tip:perfcounters/urgent] perf stat: Define MATCH_EVENT for easy attr checking tip-bot for Jaswinder Singh Rajput
2009-07-01 11:45 ` [GIT-PULL -tip][PATCH 0/6] perf_counter patches Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090703082734.GE21833@elte.hu \
--to=mingo@elte.hu \
--cc=jaswinder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox