From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Valdis.Kletnieks@vt.edu, linux-kernel@vger.kernel.org,
James Morris <jmorris@namei.org>,
David Howells <dhowells@redhat.com>,
Roland McGrath <roland@redhat.com>
Subject: [PATCH] selinux_bprm_committed_creds: use __wake_up_parent()
Date: Fri, 3 Jul 2009 11:23:11 +0200 [thread overview]
Message-ID: <20090703092311.GA3712@redhat.com> (raw)
In-Reply-To: <20090703081821.GA4051@redhat.com>
(depends on ptrace-__ptrace_detach-do-__wake_up_parent-if-we-reap-the-tracee.patch
which exports __wake_up_parent)
Spotted by Valdis.Kletnieks@vt.edu.
selinux_bprm_committed_creds() should not play with ->wait_chldexit, now
that __wake_up_parent() is exported change the code to use this helper.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
--- WAIT/security/selinux/hooks.c~SEL_WAKE_PARENT 2009-06-16 17:01:42.000000000 +0200
+++ WAIT/security/selinux/hooks.c 2009-07-03 11:15:08.000000000 +0200
@@ -2404,7 +2404,7 @@ static void selinux_bprm_committed_creds
/* Wake up the parent if it is waiting so that it can recheck
* wait permission to the new task SID. */
read_lock(&tasklist_lock);
- wake_up_interruptible(¤t->real_parent->signal->wait_chldexit);
+ __wake_up_parent(current, current->real_parent);
read_unlock(&tasklist_lock);
}
next prev parent reply other threads:[~2009-07-03 9:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-30 19:51 mmotm 2009-06-30-12-50 uploaded akpm
2009-06-30 20:15 ` Valdis.Kletnieks
2009-06-30 20:19 ` Randy Dunlap
2009-06-30 20:35 ` Andrew Morton
2009-06-30 20:39 ` Randy Dunlap
2009-06-30 20:27 ` Valdis.Kletnieks
2009-06-30 20:38 ` Andrew Morton
2009-07-01 9:21 ` KOSAKI Motohiro
2009-07-02 13:51 ` Valdis.Kletnieks
2009-06-30 21:49 ` [PATCH mmotm] hwmon: fix lis3-spi for CONFIG_PM=n Randy Dunlap
2009-07-02 19:16 ` mmotm 2009-06-30-12-50 uploaded Valdis.Kletnieks
2009-07-02 19:47 ` Andrew Morton
2009-07-02 20:21 ` Valdis.Kletnieks
2009-07-03 10:25 ` Valdis.Kletnieks
2009-07-03 1:52 ` mmotm 2009-06-30-12-50 dies during early boot Valdis.Kletnieks
2009-07-03 2:20 ` Andrew Morton
2009-07-03 8:20 ` Oleg Nesterov
2009-07-03 9:23 ` Oleg Nesterov [this message]
2009-07-03 9:39 ` [PATCH] selinux_bprm_committed_creds: use __wake_up_parent() James Morris
2009-07-03 10:12 ` Valdis.Kletnieks
2009-07-03 10:46 ` Oleg Nesterov
2009-07-03 10:16 ` David Howells
2009-07-03 16:11 ` Andrew Morton
2009-07-04 8:14 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090703092311.GA3712@redhat.com \
--to=oleg@redhat.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox