From: Jens Axboe <jens.axboe@oracle.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Matthew Wilcox <matthew@wil.cx>,
linux-kernel@vger.kernel.org, "Styner,
Douglas W" <douglas.w.styner@intel.com>,
Chinang Ma <chinang.ma@intel.com>,
"Prickett, Terry O" <terry.o.prickett@intel.com>,
Matthew Wilcox <matthew.r.wilcox@intel.com>,
Eric.Moore@lsi.com, DL-MPTFusionLinux@lsi.com
Subject: Re: >10% performance degradation since 2.6.18
Date: Fri, 3 Jul 2009 20:54:14 +0200 [thread overview]
Message-ID: <20090703185414.GP23611@kernel.dk> (raw)
In-Reply-To: <87skhdaaub.fsf@basil.nowhere.org>
On Fri, Jul 03 2009, Andi Kleen wrote:
>
> Matthew Wilcox <matthew@wil.cx> writes:
> >
> > ======oprofile CPU_CLK_UNHALTED for top 30 functions
> > Cycles% 2.6.18-92.el5-op Cycles% 2.6.30
> > 70.1409 <database> 67.0207 <database>
> > 1.3556 mpt_interrupt 1.7029 mpt_interrupt
>
> It's strange that mpt_interrupt is that more costly in 2.6.30
> than in 2.6.18. I diffed 2.6.30's drivers/message/fusion/mptbase.c
> to a rhel 5.3s and they seem to be about the same.
>
> So why does it cost 0.5% more in 2.6.30?
>
> [adding MPT maintainers]
Look at the irqs/sec rate, it's higher by about the same percentage. So
it's likely not a more costly irq handler, it's likely just called that
much more. It could be IO pattern, causing more commands to be issued
(which leads to more interrupts, etc).
> > 1.1622 __blockdev_direct_IO 1.1443 kmem_cache_alloc
>
> It would be interesting to find out why kmem_cache_alloc
> is that more expensive. Either it is called more or the allocator
> is slower. Any chance of a callgraph profile run so we
> can see the callers?
Could be more IO as well, that hits the allocate often.
I agree with some callgraph data, that would at least eliminate the
guessing here. And some detailed IO statistics, amount of data
transferred as well as iostat info to see if the pattern is
significantly worse.
--
Jens Axboe
next prev parent reply other threads:[~2009-07-03 18:54 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-03 2:56 >10% performance degradation since 2.6.18 Matthew Wilcox
2009-07-03 17:04 ` Paul E. McKenney
2009-07-03 18:19 ` Andi Kleen
2009-07-03 18:54 ` Jens Axboe [this message]
2009-07-03 19:13 ` Matthew Wilcox
2009-07-03 19:22 ` Jens Axboe
2009-07-03 19:45 ` Matthew Wilcox
2009-07-03 19:54 ` Andi Kleen
2009-07-03 20:04 ` Arjan van de Ven
2009-07-03 23:35 ` Andi Kleen
2009-07-04 6:04 ` Arjan van de Ven
2009-07-04 8:44 ` Andi Kleen
2009-07-04 9:19 ` Jeff Garzik
2009-07-05 4:01 ` Herbert Xu
2009-07-05 13:09 ` Matthew Wilcox
2009-07-05 16:11 ` Herbert Xu
2009-07-06 8:38 ` Andi Kleen
2009-07-05 20:44 ` Jeff Garzik
2009-07-06 1:19 ` Herbert Xu
2009-07-06 8:45 ` Andi Kleen
2009-07-06 17:00 ` Rick Jones
2009-07-06 17:36 ` Ma, Chinang
2009-07-06 17:42 ` Matthew Wilcox
2009-07-06 17:57 ` Ma, Chinang
2009-07-06 18:05 ` Matthew Wilcox
2009-07-06 18:48 ` Ma, Chinang
2009-07-06 18:53 ` Matthew Wilcox
2009-07-06 21:16 ` Ma, Chinang
2009-07-07 8:16 ` Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2009-07-05 11:00 Daniel J Blueman
2009-07-06 21:58 ` Chetan.Loke
2009-07-07 22:05 ` Daniel J Blueman
2009-07-08 15:03 ` Chetan.Loke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090703185414.GP23611@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=DL-MPTFusionLinux@lsi.com \
--cc=Eric.Moore@lsi.com \
--cc=andi@firstfloor.org \
--cc=chinang.ma@intel.com \
--cc=douglas.w.styner@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.r.wilcox@intel.com \
--cc=matthew@wil.cx \
--cc=terry.o.prickett@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox