Re: [PATCH v3] gpio: add Intel Moorestown Platform Langwell chip gpio driver

Russell King
2009-09-18T07:50:20Z

On Thu, Sep 17, 2009 at 08:38:26PM -0700, Andrew Morton wrote:
> On Fri, 18 Sep 2009 09:18:44 +0800 Alek Du <alek.du@intel.com> wrote:
>
> > Sorry for the inconvenience. I do not have SPARC64 build env., but I think this patch will fix the build issue, I should include <linux/irq.h> by explicit.
> >
> > >From 5f0f166b37c4313c27de32f6f200bbd0656603b7 Mon Sep 17 00:00:00 2001
> > From: Alek Du <alek.du@intel.com>
> > Date: Fri, 18 Sep 2009 09:09:19 +0800
> > Subject: [PATCH] gpio: Fix Langwell gpio driver build error
> >
> > Need to include <linux/irq.h> directly ...
> >
> > Signed-off-by: Alek Du <alek.du@intel.com>
> > ---
> > drivers/gpio/langwell_gpio.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/gpio/langwell_gpio.c b/drivers/gpio/langwell_gpio.c
> > index e100583..10a1172 100644
> > --- a/drivers/gpio/langwell_gpio.c
> > +++ b/drivers/gpio/langwell_gpio.c
> > @@ -27,6 +27,7 @@
> > #include <linux/interrupt.h>
> > #include <linux/init.h>
> > #include <linux/io.h>
> > +#include <linux/irq.h>
> > #include <linux/gpio.h>
> >
> > struct lnw_gpio_register {
>
> include/linux/irq.h says
>
> /*
> * Please do not include this file in generic code. There is currently
> * no requirement for any architecture to implement anything held
> * within this file.
> *
> * Thanks. --rmk
> */
>
> but
>
> y:/usr/src/linux-2.6.31> grep -rl 'linux/irq.h' drivers | wc -l
> 101
>
> Russell, is that rule no longer true?

Ever since ARM was converted over to genirq, I've given up fighting it.
It does still mean that any arch not using genirq is going to have
problems with these drivers.

I suspect that it's still the case that many of these includes should
be linux/interrupt.h and not linux/irq.h

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/