Re: [PATCH v3] gpio: add Intel Moorestown Platform Langwell chip gpio driver

Andrew Morton
2009-09-18T03:38:45Z

On Fri, 18 Sep 2009 09:18:44 +0800 Alek Du <alek.du@intel.com> wrote:

> Sorry for the inconvenience. I do not have SPARC64 build env., but I think this patch will fix the build issue, I should include <linux/irq.h> by explicit.
>
> >From 5f0f166b37c4313c27de32f6f200bbd0656603b7 Mon Sep 17 00:00:00 2001
> From: Alek Du <alek.du@intel.com>
> Date: Fri, 18 Sep 2009 09:09:19 +0800
> Subject: [PATCH] gpio: Fix Langwell gpio driver build error
>
> Need to include <linux/irq.h> directly ...
>
> Signed-off-by: Alek Du <alek.du@intel.com>
> ---
> drivers/gpio/langwell_gpio.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpio/langwell_gpio.c b/drivers/gpio/langwell_gpio.c
> index e100583..10a1172 100644
> --- a/drivers/gpio/langwell_gpio.c
> +++ b/drivers/gpio/langwell_gpio.c
> @@ -27,6 +27,7 @@
> #include <linux/interrupt.h>
> #include <linux/init.h>
> #include <linux/io.h>
> +#include <linux/irq.h>
> #include <linux/gpio.h>
>
> struct lnw_gpio_register {

include/linux/irq.h says

/*
* Please do not include this file in generic code. There is currently
* no requirement for any architecture to implement anything held
* within this file.
*
* Thanks. --rmk
*/

but

y:/usr/src/linux-2.6.31> grep -rl 'linux/irq.h' drivers | wc -l
101

Russell, is that rule no longer true?

Thanks.