From: Ingo Molnar <mingo@elte.hu>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Mike Galbraith <efault@gmx.de>, Paul Mackerras <paulus@samba.org>,
Anton Blanchard <anton@samba.org>,
Jens Axboe <jens.axboe@oracle.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH 5/5] perf report: Support callchains with relative overhead rate
Date: Sun, 5 Jul 2009 10:59:49 +0200 [thread overview]
Message-ID: <20090705085949.GA23780@elte.hu> (raw)
In-Reply-To: <20090705083400.GB12783@elte.hu>
btw., i get some buggy looking output with:
$ perf record -f -g ~/hackbench 10
$ perf report -c
|--5.11%-- unix_stream_sendmsg
| |
| |--100.00%-- __sock_sendmsg
| | sock_aio_write
| | do_sync_write
| | vfs_write
| | sys_write
| | sysenter_dispatch
| | 0xf7f72430
| | 0xffebbca000000014
| |
| --11.11%-- sock_aio_write
| do_sync_write
| vfs_write
| sys_write
| sysenter_dispatch
| 0xf7f72430
| 0xffebbca000000014
Those percentages dont sum up to 100% :-)
Another detail: i think we should signal when we crop the output due
to the filter, via a line of:
| [...]
or so.
Plus, when doing 'perf report' on a call-chain recording, shouldnt
we auto-detect this fact and default to fractal output
automatically, instead of flat mode?
User can still force flat mode via 'perf report -c flat'.
Ingo
next prev parent reply other threads:[~2009-07-05 9:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-05 5:39 [PATCH 1/5] perf report: Warn on callchain output request from non-callchain file Frederic Weisbecker
2009-07-05 5:39 ` [PATCH 2/5] perf report: Use a modifiable string for default callchain options Frederic Weisbecker
2009-07-05 9:52 ` [tip:perfcounters/urgent] " tip-bot for Frederic Weisbecker
2009-07-05 5:39 ` [PATCH 3/5] perf report: Change default callchain parameters Frederic Weisbecker
2009-07-05 9:52 ` [tip:perfcounters/urgent] " tip-bot for Frederic Weisbecker
2009-07-05 5:39 ` [PATCH 4/5] perf tools: callchains: Manage the cumul hits on the fly Frederic Weisbecker
2009-07-05 9:52 ` [tip:perfcounters/urgent] perf_counter " tip-bot for Frederic Weisbecker
2009-07-05 5:39 ` [PATCH 5/5] perf report: Support callchains with relative overhead rate Frederic Weisbecker
2009-07-05 8:34 ` Ingo Molnar
2009-07-05 8:59 ` Ingo Molnar [this message]
2009-07-05 13:23 ` Frederic Weisbecker
2009-07-05 13:19 ` Frederic Weisbecker
2009-07-05 9:52 ` [tip:perfcounters/urgent] perf report: Add "Fractal" mode output - support " tip-bot for Frederic Weisbecker
2009-07-05 9:51 ` [tip:perfcounters/urgent] perf report: Warn on callchain output request from non-callchain file tip-bot for Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090705085949.GA23780@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=anton@samba.org \
--cc=efault@gmx.de \
--cc=fweisbec@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox