From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756075AbZGELWS (ORCPT ); Sun, 5 Jul 2009 07:22:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753437AbZGELWI (ORCPT ); Sun, 5 Jul 2009 07:22:08 -0400 Received: from mga14.intel.com ([143.182.124.37]:48539 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752518AbZGELWI (ORCPT ); Sun, 5 Jul 2009 07:22:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.42,351,1243839600"; d="scan'208";a="161637243" Date: Sun, 5 Jul 2009 19:21:59 +0800 From: Wu Fengguang To: KOSAKI Motohiro Cc: LKML , linux-mm , Andrew Morton , Christoph Lameter , David Rientjes , Rik van Riel Subject: Re: [PATCH 2/5] add buffer cache information to show_free_areas() Message-ID: <20090705112159.GB1898@localhost> References: <20090705181400.08F1.A69D9226@jp.fujitsu.com> <20090705182337.08F9.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090705182337.08F9.A69D9226@jp.fujitsu.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 05, 2009 at 05:24:07PM +0800, KOSAKI Motohiro wrote: > Subject: [PATCH] add buffer cache information to show_free_areas() > > When administrator analysis memory shortage reason from OOM log, They > often need to know rest number of cache like pages. nr_blockdev_pages() pages are also accounted in NR_FILE_PAGES. > Then, show_free_areas() shouldn't only display page cache, but also it > should display buffer cache. So if we are to add this, I'd suggest to put it close to the total pagecache line: printk("%ld total pagecache pages\n", global_page_state(NR_FILE_PAGES)); + printk("%ld blkdev pagecache pages\n", nr_blockdev_pages()); Thanks, Fengguang > > Signed-off-by: KOSAKI Motohiro > --- > mm/page_alloc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > Index: b/mm/page_alloc.c > =================================================================== > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -2118,7 +2118,7 @@ void show_free_areas(void) > printk("Active_anon:%lu active_file:%lu inactive_anon:%lu\n" > " inactive_file:%lu" > " unevictable:%lu" > - " dirty:%lu writeback:%lu unstable:%lu\n" > + " dirty:%lu writeback:%lu buffer:%lu unstable:%lu\n" > " free:%lu slab_reclaimable:%lu slab_unreclaimable:%lu\n" > " mapped:%lu pagetables:%lu bounce:%lu\n", > global_page_state(NR_ACTIVE_ANON), > @@ -2128,6 +2128,7 @@ void show_free_areas(void) > global_page_state(NR_UNEVICTABLE), > global_page_state(NR_FILE_DIRTY), > global_page_state(NR_WRITEBACK), > + K(nr_blockdev_pages()), > global_page_state(NR_UNSTABLE_NFS), > global_page_state(NR_FREE_PAGES), > global_page_state(NR_SLAB_RECLAIMABLE), >