From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756473AbZGEMNZ (ORCPT ); Sun, 5 Jul 2009 08:13:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754160AbZGEMNS (ORCPT ); Sun, 5 Jul 2009 08:13:18 -0400 Received: from mga14.intel.com ([143.182.124.37]:40018 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753845AbZGEMNR (ORCPT ); Sun, 5 Jul 2009 08:13:17 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.42,351,1243839600"; d="scan'208";a="161644864" Date: Sun, 5 Jul 2009 20:13:08 +0800 From: Wu Fengguang To: KOSAKI Motohiro Cc: LKML , linux-mm , Andrew Morton , Christoph Lameter , David Rientjes , Rik van Riel Subject: Re: [PATCH 5/5] add NR_ANON_PAGES to OOM log Message-ID: <20090705121308.GC5252@localhost> References: <20090705181400.08F1.A69D9226@jp.fujitsu.com> <20090705182533.0902.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090705182533.0902.A69D9226@jp.fujitsu.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 05, 2009 at 05:26:18PM +0800, KOSAKI Motohiro wrote: > Subject: [PATCH] add NR_ANON_PAGES to OOM log > > show_free_areas can display NR_FILE_PAGES, but it can't display > NR_ANON_PAGES. > > this patch fix its inconsistency. > > > Reported-by: Wu Fengguang > Signed-off-by: KOSAKI Motohiro > --- > mm/page_alloc.c | 1 + > 1 file changed, 1 insertion(+) > > Index: b/mm/page_alloc.c > =================================================================== > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -2216,6 +2216,7 @@ void show_free_areas(void) > printk("= %lukB\n", K(total)); > } > > + printk("%ld total anon pages\n", global_page_state(NR_ANON_PAGES)); > printk("%ld total pagecache pages\n", global_page_state(NR_FILE_PAGES)); Can we put related items together, ie. this looks more friendly: Anon:XXX active_anon:XXX inactive_anon:XXX File:XXX active_file:XXX inactive_file:XXX Thanks, Fengguang