From: Cyrill Gorcunov <gorcunov@gmail.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Yinghai Lu <yinghai@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC -tip] x86,apic -- reduce disable_apic usage
Date: Sun, 5 Jul 2009 20:59:47 +0400 [thread overview]
Message-ID: <20090705165947.GD4791@lenovo> (raw)
In-Reply-To: <alpine.LFD.2.00.0907051737100.13862@eddie.linux-mips.org>
[Maciej W. Rozycki - Sun, Jul 05, 2009 at 05:38:52PM +0100]
| On Sun, 5 Jul 2009, Cyrill Gorcunov wrote:
|
| > Here is an attempt to bring more consistency for apic
| > presence check. I hope I covered all the code flows.
| > Though it's RFC. Please review and test if possible.
| >
| > -- Cyrill
| > ---
| > Instead of messing with (cpu_has_apic|disable_apic)
| > to check if we have apic functional, better to distinguish
| > them by logical kind. cpu_has_apic -- to check if we may
| > use apic functionality, disable_apic -- to note that
| > apic was disabled via command line.
|
| How do you set cpu_has_apic for systems with discrete local APICs? The
| CPUID flag is not set in this case.
|
| Maciej
| --
|
Well, indeed, somehow forgot about this case. Thanks Maciej!
The patch should be dropped.
-- Cyrill
next prev parent reply other threads:[~2009-07-05 16:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-05 16:20 [RFC -tip] x86,apic -- reduce disable_apic usage Cyrill Gorcunov
2009-07-05 16:38 ` Maciej W. Rozycki
2009-07-05 16:59 ` Cyrill Gorcunov [this message]
2009-07-05 17:12 ` Cyrill Gorcunov
2009-07-05 17:17 ` Cyrill Gorcunov
2009-07-05 17:47 ` Maciej W. Rozycki
2009-07-05 18:12 ` Cyrill Gorcunov
2009-07-05 17:30 ` H. Peter Anvin
2009-07-05 19:02 ` Cyrill Gorcunov
2009-07-05 19:18 ` H. Peter Anvin
2009-07-05 19:46 ` Cyrill Gorcunov
2009-07-07 23:49 ` Maciej W. Rozycki
2009-07-08 14:44 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090705165947.GD4791@lenovo \
--to=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox