public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>,
	Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	Yinghai Lu <yinghai@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC -tip] x86,apic -- reduce disable_apic usage
Date: Sun, 5 Jul 2009 23:02:11 +0400	[thread overview]
Message-ID: <20090705190211.GK4791@lenovo> (raw)
In-Reply-To: <4A50E323.6060109@zytor.com>

[H. Peter Anvin - Sun, Jul 05, 2009 at 10:30:11AM -0700]
| Maciej W. Rozycki wrote:
| > 
| >  How do you set cpu_has_apic for systems with discrete local APICs?  The 
| > CPUID flag is not set in this case.
| > 
| 
| Well, should it be?  We do set flags when they're appropriate to us, and
| if the semantics are such as that is inappropriate we can set a custom bit.
| 
| 	-hpa
| 

Peter, Maciej but how kernel behaved on older cpu long time ago?

I mean -- should user pass "lapic" cmdline option too be
able to use apic functionality? (i'm asking since I just
don't know how it had been working before). Current
code (if only I'm not _missing_ something) relies on cpu_has_apic
bit. And even if MP table has been parsed and APIC base found,
cpu_has_apic could be not set so detect_init_APIC will fail
if no "lapic" option passed (in case of old cpu without this cpuid
bit produced) as we eventually stay with pic mode.

	-- Cyrill

  reply	other threads:[~2009-07-05 19:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-05 16:20 [RFC -tip] x86,apic -- reduce disable_apic usage Cyrill Gorcunov
2009-07-05 16:38 ` Maciej W. Rozycki
2009-07-05 16:59   ` Cyrill Gorcunov
2009-07-05 17:12     ` Cyrill Gorcunov
2009-07-05 17:17       ` Cyrill Gorcunov
2009-07-05 17:47         ` Maciej W. Rozycki
2009-07-05 18:12           ` Cyrill Gorcunov
2009-07-05 17:30   ` H. Peter Anvin
2009-07-05 19:02     ` Cyrill Gorcunov [this message]
2009-07-05 19:18       ` H. Peter Anvin
2009-07-05 19:46         ` Cyrill Gorcunov
2009-07-07 23:49     ` Maciej W. Rozycki
2009-07-08 14:44       ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090705190211.GK4791@lenovo \
    --to=gorcunov@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=macro@linux-mips.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox