From: Arnd Bergmann <arnd@arndb.de>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: davem@davemloft.net, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org, reif@earthlink.net
Subject: Re: [PATCH 2/5] sparc: use asm-generic/dma-mapping-common.h
Date: Mon, 6 Jul 2009 10:26:28 +0200 [thread overview]
Message-ID: <200907061026.28878.arnd@arndb.de> (raw)
In-Reply-To: <1246860820-20629-3-git-send-email-fujita.tomonori@lab.ntt.co.jp>
On Monday 06 July 2009, FUJITA Tomonori wrote:
> +static inline struct dma_map_ops *get_dma_ops(struct device *dev)
> +{
> + return dma_ops;
> +}
> +
> +#define flush_write_buffers()
> +
> +#include <asm-generic/dma-mapping-common.h>
I still think the flush_write_buffers() x86-ism should not be required
to use dma-mapping-common.h and only be used in arch/x86/kernel/pci-nommu.c
so you don't have to add dummy definitions to all architectures.
See http://lkml.org/lkml/2009/6/30/134
Otherwise, your series looks good!
Arnd <><
next prev parent reply other threads:[~2009-07-06 8:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-06 6:13 [PATCH 0/5] sparc: use asm-generic/dma-mapping-common.h and pci-dma-compat.h FUJITA Tomonori
2009-07-06 6:13 ` [PATCH 1/5] sparc: use dma_map_ops struct FUJITA Tomonori
2009-07-06 6:13 ` [PATCH 2/5] sparc: use asm-generic/dma-mapping-common.h FUJITA Tomonori
2009-07-06 8:26 ` Arnd Bergmann [this message]
2009-07-07 1:11 ` David Miller
2009-07-09 9:55 ` FUJITA Tomonori
2009-07-09 12:29 ` Arnd Bergmann
2009-07-06 6:13 ` [PATCH 3/5] sparc: remove no-op dma_4v_sync_single_for_cpu and dma_4v_sync_sg_for_cpu FUJITA Tomonori
2009-07-06 6:13 ` [PATCH 4/5] sparc: replace sbus_map_single and sbus_unmap_single with sbus_map_page and sbus_unmap_page FUJITA Tomonori
2009-07-06 6:13 ` [PATCH 5/5] sparc: use asm-generic/pci-dma-compat FUJITA Tomonori
2009-07-06 8:21 ` Arnd Bergmann
2009-07-07 0:07 ` [PATCH 0/5] sparc: use asm-generic/dma-mapping-common.h and pci-dma-compat.h Robert Reif
2009-07-07 1:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907061026.28878.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=reif@earthlink.net \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox