Re: [GIT PULL] [PATCH 0/22] trivial fixes typo "foo foo"

[Jesse Barnes <jbarnes@virtuousgeek.org>]

On Tue, 07 Jul 2009 16:44:00 +0100
David Howells <dhowells@redhat.com> wrote:

> Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:
> 
> > Jaswinder Singh Rajput (22):
> >       trivial: fix typo "has has" in multiple files
> >       trivial: fix typo "on on" in multiple files
> >       trivial: fix typo "that that" in multiple files
> 
> NAK.  You can't just mechanically reduce the above pairs of words to
> a single instance unconditionally.
> 
> "has has" should perhaps be "has had" in some cases.
> 
> In "on on", the first preposition may be part of a compound verb (eg:
> "to go on").
> 
> In "that that", the second "that" may be specifying the object in
> relation to a previous part of the text.

What's more, these types of patchsets don't actually improve things in
any real way.  If these changes were submitted as part of some greater
work, involving clarifying the text or making the text match the code,
or cleaning up the code in some real way (refactoring common stuff etc)
I'd be fine with it.

But as it stands it just makes lkml that much more difficult to read,
and clogs the changelog with fairly useless bits.  But maybe I'm
missing the "greater work" part of this set; I haven't looked at all 22
patches here.

-- 
Jesse Barnes, Intel Open Source Technology Center